From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/3] Use default ACCM (0xffffffff) to trasmit package
Date: Thu, 20 Jan 2011 13:10:47 -0600 [thread overview]
Message-ID: <4D3888B7.9020606@gmail.com> (raw)
In-Reply-To: <1295502354-19270-2-git-send-email-martin.xu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
Hi Martin,
On 01/19/2011 11:45 PM, martin.xu(a)intel.com wrote:
> From: Martin Xu <martin.xu@intel.com>
>
> Using my Huawei EM770W modem, if set ACCM as 0x00000000, RXJ-
> event breaks PPP link, after IP package transmit for a while.
> Using default ACCM, the issue can be fixed.
> I tested it at China Unicom networks.
Does the Huawei NAK our ACCM by any chance?
> ---
> gatchat/ppp_lcp.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/gatchat/ppp_lcp.c b/gatchat/ppp_lcp.c
> index cc3e231..2264731 100644
> --- a/gatchat/ppp_lcp.c
> +++ b/gatchat/ppp_lcp.c
> @@ -105,8 +105,7 @@ static void lcp_generate_config_options(struct lcp_data *lcp)
>
> static void lcp_reset_config_options(struct lcp_data *lcp)
> {
> - lcp->req_options = REQ_OPTION_ACCM;
> - lcp->accm = 0;
> + /* Using the default ACCM */
>
> lcp_generate_config_options(lcp);
> }
> @@ -155,7 +154,11 @@ static void lcp_rca(struct pppcp_data *pppcp, const struct pppcp_packet *packet)
> * which control characters MUST remain mapped when
> * the peer sends them.
> */
> - ppp_set_recv_accm(pppcp_get_ppp(pppcp), 0);
> +
> + /*
> + * Using the default ACCM
> + * ppp_set_recv_accm(pppcp_get_ppp(pppcp), ~0U);
> + */
If you follow my advice for path 1, then this chunk isn't necessary.
> break;
> default:
> break;
Regards,
-Denis
next prev parent reply other threads:[~2011-01-20 19:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 5:45 [PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue martin.xu
2011-01-20 5:45 ` [PATCH 2/3] Use default ACCM (0xffffffff) to trasmit package martin.xu
2011-01-20 5:45 ` [PATCH 3/3] Huawei: set Huawei EM770W modem device to 00 martin.xu
2011-01-20 18:22 ` Lucas De Marchi
2011-01-20 19:10 ` Denis Kenzior [this message]
2011-01-21 1:51 ` [PATCH 2/3] Use default ACCM (0xffffffff) to trasmit package Xu, Martin
2011-01-21 20:07 ` Denis Kenzior
2011-01-20 19:08 ` [PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue Denis Kenzior
2011-01-21 2:09 ` Xu, Martin
2011-01-21 20:10 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3888B7.9020606@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox