From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/6] gprs-provision: add driver API header
Date: Fri, 21 Jan 2011 11:44:24 -0600 [thread overview]
Message-ID: <4D39C5F8.4040004@gmail.com> (raw)
In-Reply-To: <1295595558.21986.35.camel@jsaunama-desktop>
[-- Attachment #1: Type: text/plain, Size: 1632 bytes --]
Hi Jukka,
On 01/21/2011 01:39 AM, Jukka Saunamaki wrote:
> Hi
>
> On Thu, 2011-01-20 at 15:51 -0600, Denis Kenzior wrote:
>> So I don't really see the point in an asynchronous provisioning driver.
>> If you want to do this over D-Bus or something then you might as well
>> provision via the ConnectionManager interface. The other problem with
>> being async is that is nearly impossible to support multiple
>> provisioning plugins properly. I'd rather not deal with the race
>> conditions.
>>
>> If we can't make the lookup fast enough to be done synchronously, then I
>> think we should give up.
>
> The reason for asyncronous API is still that SPN value reading from SIM.
> Is there any way to make sure it is available synchronously when
> provisioning is run?
Not really. So you're introducing a boatload of extra complexity just
because of the need for EFspn? Are you 100% sure that you really need
this? Can some of these corner cases be covered differently?
> And what do you mean with it being impossible to support multiple
> provisioning plugins properly? Plugins are run one after another until
> first returns something.
> Race conditions I tried to address in gprs, so if gprs atom goes away
> while provisioning is running nothing bad should happen. But sure, there
> might something else, and hopefully someone could point them.
How exactly are you guaranteeing that 'nothing bad should happen'?
There is no cancellation mechanism that I see. Not to mention that the
current ofono_sim_read API is not even safe either. For exactly the
same reasons.
Regards,
-Denis
next prev parent reply other threads:[~2011-01-21 17:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 13:11 [gprs-provision PATCHv5 0/6] Plugin API for provisioning of GPRS context setting Jukka Saunamaki
2011-01-20 13:11 ` [PATCH 1/6] gprs-provision: add driver API header Jukka Saunamaki
2011-01-20 21:51 ` Denis Kenzior
2011-01-21 7:39 ` Jukka Saunamaki
2011-01-21 17:44 ` Denis Kenzior [this message]
2011-01-24 7:10 ` Jukka Saunamaki
2011-01-24 10:16 ` Aki Niemi
2011-01-24 10:38 ` Aki Niemi
2011-01-20 13:11 ` [PATCH 2/6] ofono.h: add new atom type for gprs-provision Jukka Saunamaki
2011-01-20 13:11 ` [PATCH 3/6] gprs-provision: add driver API sources Jukka Saunamaki
2011-01-20 13:11 ` [PATCH 4/6] modem: probe gprs_provision drivers Jukka Saunamaki
2011-01-20 13:11 ` [PATCH 5/6] gprs: add gprs context provisioning Jukka Saunamaki
2011-01-20 13:11 ` [PATCH 6/6] gprs-provision: add example context provisioning driver Jukka Saunamaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D39C5F8.4040004@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox