From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: voicecall: behavior of ReleaseAndAnswere with held calls?
Date: Tue, 25 Jan 2011 17:32:18 -0600 [thread overview]
Message-ID: <4D3F5D82.4060101@gmail.com> (raw)
In-Reply-To: <AANLkTinwec10=fv5sHM4+VeBEcJnQXMAtQva5FPBCV0E@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]
> Yep, Hangup or HangupMultiparty then SwapCalls. If you feel that a
> single operation to accomplish hangup + swap is required we can
> certainly consider it. For now it didn't pass our API is Minimal +
> Complete test. Perhaps ReleaseAndSwap()...?
>
>
> I would go with easy solution by just changing src/voicecall.c line 1418
>
> static DBusMessage *manager_release_and_answer(DBusConnection *conn,
> DBusMessage *msg, void *data)
> {
> ...
>
> 1418:
> - if (!voicecalls_have_waiting(vc))
> + if (!voicecalls_have_waiting(vc) &&
I guess you mean || here.
> !voicecalls_have_with_status(vc, CALL_STATUS_HELD))
> return __ofono_error_failed(msg);
>
> ...
> vc->driver->release_all_active(vc, generic_callback, vc);
>
> return NULL;
> }
>
> This would give ReleaseAndAnswer full functionality of +CHLD=1.
>
> (sorry for pseudo-patch, working temporary on windows machine)
>
>
Anyhow, I don't agree, we want the API to reflect what is going to
happen. The various scenarios involving CHLD are pretty bizarre and
hard to explain to a developer who hasn't learned 22.030 by heart.
Regards,
-Denis
prev parent reply other threads:[~2011-01-25 23:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 12:07 voicecall: behavior of ReleaseAndAnswere with held calls? Tomasz GREGOREK
2011-01-25 20:37 ` Denis Kenzior
2011-01-25 21:43 ` Tomasz Gregorek
2011-01-25 22:01 ` Denis Kenzior
2011-01-25 22:18 ` Tomasz Gregorek
2011-01-25 23:32 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3F5D82.4060101@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox