From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 02/12] gprs: driver interface changes for IPv6
Date: Fri, 04 Feb 2011 11:24:29 -0600 [thread overview]
Message-ID: <4D4C364D.90201@gmail.com> (raw)
In-Reply-To: <1296723809-32676-3-git-send-email-mika.liljeberg@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]
Hi Mika,
> +enum ofono_gprs_addrconf {
> + OFONO_GPRS_ADDRCONF_NONE,
> + OFONO_GPRS_ADDRCONF_STATIC,
> + OFONO_GPRS_ADDRCONF_DHCP,
> +};
> +
What exactly is the _NONE addrconf for? And why don't we use a gboolean
here like before?
> struct ofono_gprs_primary_context {
> unsigned int cid;
> int direction;
> @@ -94,6 +101,20 @@ struct ofono_modem *ofono_gprs_context_get_modem(struct ofono_gprs_context *gc);
>
> void ofono_gprs_context_set_type(struct ofono_gprs_context *gc,
> enum ofono_gprs_context_type type);
> +void ofono_gprs_context_set_interface(struct ofono_gprs_context *gc,
> + const char *interface);
> +void ofono_gprs_context_set_ip_addrconf(struct ofono_gprs_context *gc,
> + enum ofono_gprs_addrconf method);
> +void ofono_gprs_context_set_ip_address(struct ofono_gprs_context *gc,
> + const char *address);
> +void ofono_gprs_context_set_ip_netmask(struct ofono_gprs_context *gc,
> + const char *netmask);
> +void ofono_gprs_context_set_ip_gateway(struct ofono_gprs_context *gc,
> + const char *netmask);
> +void ofono_gprs_context_set_ipv6_address(struct ofono_gprs_context *gc,
> + const char *address);
> +void ofono_gprs_context_set_dns_servers(struct ofono_gprs_context *gc,
> + const char **dns);
>
So I'm actually fine with this approach.
> #ifdef __cplusplus
> }
Regards,
-Denis
next prev parent reply other threads:[~2011-02-04 17:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 9:03 [PATCH 0/12] IPv6 support Mika Liljeberg
2011-02-03 9:03 ` [PATCH 01/12] gprs: Update documentation for IPv6 Mika Liljeberg
2011-02-03 9:03 ` [PATCH 02/12] gprs: driver interface changes " Mika Liljeberg
2011-02-04 17:24 ` Denis Kenzior [this message]
2011-02-07 9:55 ` Mika.Liljeberg
2011-02-07 16:32 ` Denis Kenzior
2011-02-08 8:55 ` Mika.Liljeberg
2011-02-07 19:09 ` Marcel Holtmann
2011-02-08 8:36 ` Mika.Liljeberg
2011-02-03 9:03 ` [PATCH 03/12] gprs: core support " Mika Liljeberg
2011-02-04 17:50 ` Denis Kenzior
2011-02-07 10:12 ` Mika.Liljeberg
2011-02-03 9:03 ` [PATCH 04/12] test: modify test scripts " Mika Liljeberg
2011-02-03 9:03 ` [PATCH 05/12] isimodem: IPv6 support Mika Liljeberg
2011-02-03 9:03 ` [PATCH 06/12] atmodem: update to new gprs context interface Mika Liljeberg
2011-02-03 9:03 ` [PATCH 07/12] huaweimodem: " Mika Liljeberg
2011-02-03 9:03 ` [PATCH 08/12] mbmmodem: " Mika Liljeberg
2011-02-03 9:03 ` [PATCH 09/12] hsomodem: " Mika Liljeberg
2011-02-03 9:03 ` [PATCH 10/12] ifxmodem: " Mika Liljeberg
2011-02-03 9:03 ` [PATCH 11/12] stemodem: " Mika Liljeberg
2011-02-03 9:03 ` [PATCH 12/12] phonesim: add IPv6 support Mika Liljeberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4C364D.90201@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox