From: Andreas WESTIN <andreas.westin@stericsson.com>
To: ofono@ofono.org
Subject: Re: [PATCH 04/18] gisi: fix subscription for wgmodem2.5
Date: Wed, 16 Feb 2011 12:33:44 +0100 [thread overview]
Message-ID: <4D5BB618.1060504@stericsson.com> (raw)
In-Reply-To: <AANLkTi=aS+22cSBibi=i=2K4bcYzLbKtiJ9gtpACL-KS@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 789 bytes --]
Hi Aki,
On 2011-02-16 12:16, Aki Niemi wrote:
> Curly brackets are either in both if and else, or in neither. I
> actually prefer not to have them here, since the first line is just a
> comment in the else statement. ;)
Yes you're right :)
> This is not necessary, as a modem plugin is supposed to call
> g_isi_modem_set_device() to set the modem->device to whatever it needs
> to right after creating the GIsiModem instance.
>
> In other words, the assumption is that when the GIsiModem instace is
> actually used, all necessary internal data, such as flags and the
> remote device have already been set.
Tested and works fine, will submit a new patch for the u8500 plugin.
This is not done in the n900 plugin though, perhaps not necessary ?
Regards
Andreas
next prev parent reply other threads:[~2011-02-16 11:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 12:30 [PATCH 00/18] wgmodem2.5 support Andreas Westin
2011-02-15 12:30 ` [PATCH 01/18] gisi: pipe and pep for wgmodem2.5 Andreas Westin
2011-02-15 13:23 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-02-15 13:30 ` Mika.Liljeberg
2011-02-16 9:27 ` Andreas WESTIN
2011-02-15 12:30 ` [PATCH 02/18] gisi: modem version detection Andreas Westin
2011-02-15 12:30 ` [PATCH 03/18] isimodem: general build updates for wgmodem2.5 Andreas Westin
2011-02-16 11:19 ` Aki Niemi
2011-02-15 12:30 ` [PATCH 04/18] gisi: fix subscription " Andreas Westin
2011-02-16 11:16 ` Aki Niemi
2011-02-16 11:33 ` Andreas WESTIN [this message]
2011-02-16 11:37 ` Aki Niemi
2011-02-15 12:30 ` [PATCH 05/18] plugins: add plugin for u8500 Andreas Westin
2011-02-16 14:26 ` Aki Niemi
2011-02-16 15:27 ` Andreas WESTIN
2011-02-17 9:02 ` Aki Niemi
2011-02-15 12:31 ` [PATCH 06/18] plugins: add u8500 to udev Andreas Westin
2011-02-15 12:31 ` [PATCH 07/18] isimodem: add wgmodem2.5 to devinfo Andreas Westin
2011-02-16 14:15 ` Aki Niemi
2011-02-15 12:31 ` [PATCH 08/18] isimodem: UICC sim support for wgmodem2.5 Andreas Westin
2011-02-17 13:55 ` Aki Niemi
2011-02-15 12:31 ` [PATCH 09/18] isimodem: clip colp clir colr wgmodem2.5 Andreas Westin
2011-02-18 8:15 ` Aki Niemi
2011-02-15 12:31 ` [PATCH 10/18] isimodem: wgmodem2.5 added to voicecall Andreas Westin
2011-02-15 12:31 ` [PATCH 11/18] isimodem: gprs-context updates wgmodem2.5 Andreas Westin
2011-02-18 14:17 ` Aki Niemi
2011-02-15 12:31 ` [PATCH 12/18] isimodem: wgmodem2.5 support in USSD Andreas Westin
2011-02-15 12:31 ` [PATCH 13/18] isimodem: SS_GSM_BARRING_INFO added Andreas Westin
2011-02-15 12:31 ` [PATCH 14/18] isimodem: wgmodem2.5 added to call-forwarding Andreas Westin
2011-02-15 12:31 ` [PATCH 15/18] isimodem: wgmodem2.5 added to ssn Andreas Westin
2011-02-15 12:31 ` [PATCH 16/18] isimodem: sms updated with wgmodem2.5 Andreas Westin
2011-02-16 14:22 ` Aki Niemi
2011-02-16 14:47 ` Andreas WESTIN
2011-02-17 10:30 ` Aki Niemi
2011-02-15 12:31 ` [PATCH 17/18] isimodem: CBS for wgmodem2.5 Andreas Westin
2011-02-16 16:10 ` Denis Kenzior
2011-02-17 12:47 ` Andreas WESTIN
2011-02-15 12:31 ` [PATCH 18/18] isimodem: initial support for UICC phonebook Andreas Westin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5BB618.1060504@stericsson.com \
--to=andreas.westin@stericsson.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox