From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/9] modem.c: Go to PRE_SIM modem state on OFONO_SIM_STATE_INSERTED.
Date: Thu, 17 Feb 2011 15:00:04 -0600 [thread overview]
Message-ID: <4D5D8C54.1060408@gmail.com> (raw)
In-Reply-To: <1297756739-2958-1-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
Hi Andrew,
On 02/15/2011 01:58 AM, Andrzej Zaborowski wrote:
> The assumption so far was that SIM state would only go from
> NOT_PRESENT -> INSERTED -> READY -> NOT_PRESENT because there's
> no method to unauthenticate from SIM without removing. We need to
> be able to switch to INSERTED when SIM is being reset,
> reinitialised, etc. because going to NOT_PRESENT and then
> immediately INSERTED would be logically wrong.
> ---
> src/modem.c | 12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)
I applied this patch, but partly refactored it in a later commit. Can
you check that I didn't screw something up?
Regards,
-Denis
prev parent reply other threads:[~2011-02-17 21:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 7:58 [PATCH 1/9] modem.c: Go to PRE_SIM modem state on OFONO_SIM_STATE_INSERTED Andrzej Zaborowski
2011-02-15 7:58 ` [PATCH 2/9] sim: Implement basic Refresh Andrzej Zaborowski
2011-02-17 21:03 ` Denis Kenzior
2011-02-19 4:18 ` Andrzej Zaborowski
2011-02-15 7:58 ` [PATCH 3/9] sim: Watch for changes to relevant SIM files Andrzej Zaborowski
2011-02-17 21:08 ` Denis Kenzior
2011-02-19 4:24 ` Andrzej Zaborowski
2011-02-15 7:58 ` [PATCH 4/9] voicecall: " Andrzej Zaborowski
2011-02-17 21:08 ` Denis Kenzior
2011-02-15 7:58 ` [PATCH 5/9] network: " Andrzej Zaborowski
2011-02-17 21:09 ` Denis Kenzior
2011-02-15 7:58 ` [PATCH 6/9] cbs: " Andrzej Zaborowski
2011-02-17 21:10 ` Denis Kenzior
2011-02-15 7:58 ` [PATCH 7/9] message-waiting: " Andrzej Zaborowski
2011-02-17 20:54 ` Denis Kenzior
2011-02-15 7:58 ` [PATCH 8/9] call-forwarding: " Andrzej Zaborowski
2011-02-17 20:57 ` Denis Kenzior
2011-02-15 7:58 ` [PATCH 9/9] stk: Partially handle Refresh command Andrzej Zaborowski
2011-02-17 21:17 ` Denis Kenzior
2011-02-17 21:00 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5D8C54.1060408@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox