From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Isimodem: Crash while setting SCA
Date: Fri, 11 Mar 2011 13:59:46 -0600 [thread overview]
Message-ID: <4D7A7F32.5040408@gmail.com> (raw)
In-Reply-To: <1299847795-9935-1-git-send-email-ext-arun.1.ravindran@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
Hi Arun,
On 03/11/2011 06:49 AM, ext-arun.1.ravindran(a)nokia.com wrote:
> From: Arun Ravindran <ext-arun.1.ravindran@nokia.com>
>
> ---
> drivers/isimodem/sms.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
I applied the patch, however...
> diff --git a/drivers/isimodem/sms.c b/drivers/isimodem/sms.c
> index 957b342..c90c06d 100644
> --- a/drivers/isimodem/sms.c
> +++ b/drivers/isimodem/sms.c
> @@ -292,7 +292,7 @@ static void isi_sca_set(struct ofono_sms *sms,
> { &sd->params, sizeof(sd->params) },
> };
>
> - if (cbd == NULL || sd == NULL)
> + if (cbd == NULL || sd == NULL || sd->sim == NULL)
The check for sd == NULL is too late since sd->params is being used up
above for initialization of iov...
> goto error;
>
> bcd = sd->params.sca;
Regards,
-Denis
next prev parent reply other threads:[~2011-03-11 19:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 12:49 [PATCH] Isimodem: Crash while setting SCA ext-arun.1.ravindran
2011-03-11 19:59 ` Denis Kenzior [this message]
2011-03-14 11:49 ` Aki Niemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7A7F32.5040408@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox