From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] call-forwarding: fix for showing call forwarding states
Date: Thu, 17 Mar 2011 10:00:45 -0500 [thread overview]
Message-ID: <4D82221D.3070401@gmail.com> (raw)
In-Reply-To: <1300350356.8348.76.camel@jussi-desktop>
[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]
Hi Jussi,
>>
>> So correct me if I'm wrong, but I don't think we can do that. the
>> current cf_conditions implementation stores all conditions, which could
>> be unrelated to voice; and if my interpretation of 22.004 is correct you
>> can have something like this:
>>
>> Activate CFB for all services to Number 1
>> Activate CFU for Data services to Number 2
>>
>> Which results in cf_conditions[CALL_FORWARDING_TYPE_UNCONDITIONAL] not
>> being NULL and you reporting CFB for voice incorrectly.
>>
>> You are probably safer using is_cfu_enabled() function.
>
> As far as I know scenario you describe cannot happen with oFono. There
> is no data related conditions in the call forwarding API. Sure, you can
> set data forwarding on using SS API, but I don't see how data forwarding
> states could be shown in call forwarding API when all states in API
> start with word "voice". Also according to comments in code fax and data
> are not supported.
>
It can. oFono stores _all_ conditions in its lists. However, it
filters them when reporting the conditions in get_properties or signals.
This is why is_cfu_enabled function looks the way it does. So a
scenario like this is fully possible. Not to mention that the CFs are
queried for all services by default.
Regards,
-Denis
next prev parent reply other threads:[~2011-03-17 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 10:27 [PATCH] call-forwarding: fix for showing call forwarding states Jussi Kangas
2011-03-11 22:48 ` Denis Kenzior
2011-03-14 13:47 ` Jussi Kangas
2011-03-17 3:34 ` Denis Kenzior
2011-03-17 8:25 ` Jussi Kangas
2011-03-17 15:00 ` Denis Kenzior [this message]
2011-03-18 12:53 ` Jussi Kangas
2011-03-18 16:39 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D82221D.3070401@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox