From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/1] sms: limit the sms sending retry
Date: Thu, 17 Mar 2011 12:13:11 -0500 [thread overview]
Message-ID: <4D824127.9050604@gmail.com> (raw)
In-Reply-To: <1300379798-3390-2-git-send-email-jeevaka.badrappan@elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
Hi Jeevaka,
On 03/17/2011 11:36 AM, Jeevaka Badrappan wrote:
> ---
> src/sms.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/src/sms.c b/src/sms.c
> index 01f54dd..c4f8b54 100644
> --- a/src/sms.c
> +++ b/src/sms.c
> @@ -47,6 +47,7 @@
> #define SETTINGS_GROUP "Settings"
>
> #define TXQ_MAX_RETRIES 4
> +#define NETWORK_TIMEOUT 332
>
> static gboolean tx_next(gpointer user_data);
>
> @@ -630,6 +631,10 @@ static void tx_finished(const struct ofono_error *error, int mr, void *data)
> if (sms->registered == FALSE)
> return;
>
> + /* Retry done only for Network Timeout failure */
> + if (error->error != NETWORK_TIMEOUT)
> + goto next_q;
> +
Please also check error->type here to be CMS error.
> if (!(entry->flags & OFONO_SMS_SUBMIT_FLAG_RETRY))
> goto next_q;
>
Regards,
-Denis
next prev parent reply other threads:[~2011-03-17 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 16:36 [PATCH 0/1] Limits the send sms retry to network timeout Jeevaka Badrappan
2011-03-17 16:36 ` [PATCH 1/1] sms: limit the sms sending retry Jeevaka Badrappan
2011-03-17 17:13 ` Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-03-17 17:20 [PATCH 0/1] Limits the send sms retry to network timeout Jeevaka Badrappan
2011-03-17 17:20 ` [PATCH 1/1] sms: limit the sms sending retry Jeevaka Badrappan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D824127.9050604@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox