From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 09/12] atmodem: add gnss driver
Date: Fri, 18 Mar 2011 09:45:32 -0500 [thread overview]
Message-ID: <4D83700C.1050301@gmail.com> (raw)
In-Reply-To: <1300452632.9383.33.camel@poutijar-desktop>
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
Hi Jarko,
>>> +static gboolean gnss_parse_report(GAtResult *result, const char *prefix,
>>> + const char **xml)
>>> +{
>>> + GAtResultIter iter;
>>> +
>>> + g_at_result_iter_init(&iter, result);
>>> +
>>> + if (!g_at_result_iter_next(&iter, prefix))
>>> + return FALSE;
>>> +
>>> + if (!g_at_result_iter_next_unquoted_string(&iter, xml))
>>> + return FALSE;
>>> +
>>> + return TRUE;
>>
>> Do you really need a separate function? This might belong in gnss_report
>>
> I just thought that it would be more logical to have separate function
> to parse the result rather than putting it all in to same function. Is
> that a big deal or do you want me to change that?
This is not really wrong, was just wondering. Leave it as is for now.
Regards,
-Denis
next prev parent reply other threads:[~2011-03-18 14:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 12:22 [PATCH 00/12] basic E911 support Jarko Poutiainen
2011-03-11 12:22 ` [PATCH 01/12] dbus: add gnss interface definition Jarko Poutiainen
2011-03-18 4:26 ` Denis Kenzior
2011-03-18 12:19 ` Jarko Poutiainen
2011-03-11 12:22 ` [PATCH 02/12] include: add gnss.h file Jarko Poutiainen
2011-03-18 4:29 ` Denis Kenzior
2011-03-18 12:24 ` Jarko Poutiainen
2011-03-11 12:23 ` [PATCH 03/12] src: add atom type for gnss Jarko Poutiainen
2011-03-11 12:23 ` [PATCH 04/12] src: add gnss atom and agent implementation Jarko Poutiainen
2011-03-18 4:39 ` Denis Kenzior
2011-03-18 12:37 ` Jarko Poutiainen
2011-03-18 14:38 ` Denis Kenzior
2011-03-11 12:23 ` [PATCH 05/12] gatchat:introduce send for +CPOS Jarko Poutiainen
2011-03-11 12:23 ` [PATCH 06/12] gatchat:new hint to handle +CPOS Jarko Poutiainen
2011-03-11 12:23 ` [PATCH 07/12] gatchat: implementation for +CPOS send Jarko Poutiainen
2011-03-18 4:42 ` Denis Kenzior
2011-03-18 13:05 ` Jarko Poutiainen
2011-03-18 14:52 ` Denis Kenzior
2011-03-11 12:23 ` [PATCH 08/12] gatchat: fix gatsyntax to support +CPOS Jarko Poutiainen
2011-03-18 4:53 ` Denis Kenzior
2011-03-18 13:56 ` Jarko Poutiainen
2011-03-18 14:49 ` Denis Kenzior
2011-03-11 12:23 ` [PATCH 09/12] atmodem: add gnss driver Jarko Poutiainen
2011-03-18 5:03 ` Denis Kenzior
2011-03-18 12:50 ` Jarko Poutiainen
2011-03-18 14:45 ` Denis Kenzior [this message]
2011-03-11 12:23 ` [PATCH 10/12] ste: add support for gnss Jarko Poutiainen
2011-03-11 12:23 ` [PATCH 11/12] ofono.conf: add positioning agent interface Jarko Poutiainen
2011-03-11 12:23 ` [PATCH 12/12] test: add test-gnss Jarko Poutiainen
-- strict thread matches above, loose matches on Subject: below --
2011-03-24 13:46 [PATCH 00/12] Basic E911 support Jarko Poutiainen
2011-03-24 13:46 ` [PATCH 09/12] atmodem: add gnss driver Jarko Poutiainen
2011-03-28 23:06 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D83700C.1050301@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox