From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2] netreg: add +COPS support for HFP emulator
Date: Mon, 21 Mar 2011 14:13:47 -0500 [thread overview]
Message-ID: <4D87A36B.70000@gmail.com> (raw)
In-Reply-To: <1300718447-8033-1-git-send-email-frederic.danis@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
Hi Frédéric,
> @@ -1968,6 +2024,13 @@ void ofono_netreg_register(struct ofono_netreg *netreg)
> netreg->hfp_watch = __ofono_modem_add_atom_watch(modem,
> OFONO_ATOM_TYPE_EMULATOR_HFP,
> emulator_hfp_watch, netreg, NULL);
> +
> + hfp_atom = __ofono_modem_find_atom(modem, OFONO_ATOM_TYPE_EMULATOR_HFP);
> +
> + if (hfp_atom && __ofono_atom_get_registered(hfp_atom))
> + emulator_hfp_watch(hfp_atom,
> + OFONO_ATOM_WATCH_CONDITION_REGISTERED,
> + netreg);
There might be multiple HFP_EMULATOR atoms, so you should use
__ofono_modem_foreach_atom() here
Rest of the patch looks fine to me.
Regards,
-Denis
prev parent reply other threads:[~2011-03-21 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 14:40 [PATCH v2] netreg: add +COPS support for HFP emulator =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2011-03-21 19:13 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D87A36B.70000@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox