From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] dun: Add ATX command in emulator (X0 only)
Date: Mon, 28 Mar 2011 11:20:07 -0500 [thread overview]
Message-ID: <4D90B537.2050401@gmail.com> (raw)
In-Reply-To: <4D903D9C.6000907@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 974 bytes --]
Hi Olivier,
On 03/28/2011 02:49 AM, Olivier Guiter wrote:
> On 03/25/2011 06:36 PM, Denis Kenzior wrote:
>> Hi Olivier,
>>
>> On 03/24/2011 10:29 AM, Olivier Guiter wrote:
>>> ---
>>> src/emulator.c | 57
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>> 1 files changed, 56 insertions(+), 1 deletions(-)
>>>
>> I applied this patch, however...
>>
>> <snip>
>>
>>> + case G_AT_SERVER_REQUEST_TYPE_QUERY:
>>> + g_at_server_send_info(server, "000", TRUE);
>> This seems fishy to me. Shouldn't this be X: 0?
>>
>>> + g_at_server_send_final(server, G_AT_SERVER_RESULT_OK);
>>> + break;
>> <snip>
>>
>> Regards,
>> -Denis
> It should be ;) but i tried to keep the answer format consistent with
> other AT command answers... Maybe i m wrong ?
What other AT command answers?
Anyhow, I've reverted this patch for now since I realized that ATX is
already implemented in gatserver.c
Regards,
-Denis
prev parent reply other threads:[~2011-03-28 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 15:29 [PATCH] dun: Add ATX command in emulator (X0 only) Olivier Guiter
2011-03-25 17:36 ` Denis Kenzior
2011-03-28 7:49 ` Olivier Guiter
2011-03-28 16:20 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D90B537.2050401@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox