From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 00/12] Basic E911 support
Date: Mon, 28 Mar 2011 17:56:59 -0500 [thread overview]
Message-ID: <4D91123B.8020700@gmail.com> (raw)
In-Reply-To: <1300974396-15801-1-git-send-email-jarko.poutiainen@tieto.com>
[-- Attachment #1: Type: text/plain, Size: 1942 bytes --]
Hi Jarko,
On 03/24/2011 08:46 AM, Jarko Poutiainen wrote:
> Hi,
>
> This is third attempt to provide implementation for basic E911 support.
>
> Br,
> Jarko
>
> Jarko Poutiainen (12):
> dbus: add gnss interface definition
> include: add gnss.h file
> src: add atom type for gnss
> src: add gnss atom and agent implementation
> gatchat: introduce send for +CPOS
> gatchat: new hint to handle +CPOS
> gatchat: implementation for +CPOS send
> gatchat: fix gatsyntax to support +CPOS
> atmodem: add gnss driver
> ste: add support for gnss
> ofono.conf: add positioning agent interface
> test: add test-gnss
>
> Makefile.am | 12 +-
> drivers/atmodem/atmodem.c | 2 +
> drivers/atmodem/atmodem.h | 3 +
> drivers/atmodem/gnss.c | 282 +++++++++++++++++++++++++++++++++
> gatchat/gatchat.c | 37 ++++-
> gatchat/gatchat.h | 8 +
> gatchat/gatsyntax.c | 27 +++
> gatchat/gatsyntax.h | 3 +-
> include/dbus.h | 2 +
> include/gnss.h | 69 ++++++++
> plugins/ste.c | 8 +-
> src/gnss.c | 386 +++++++++++++++++++++++++++++++++++++++++++++
> src/gnssagent.c | 158 ++++++++++++++++++
> src/gnssagent.h | 43 +++++
> src/ofono.conf | 1 +
> src/ofono.h | 2 +
> test/test-gnss | 91 +++++++++++
> 17 files changed, 1123 insertions(+), 11 deletions(-)
> create mode 100644 drivers/atmodem/gnss.c
> create mode 100644 include/gnss.h
> create mode 100644 src/gnss.c
> create mode 100644 src/gnssagent.c
> create mode 100644 src/gnssagent.h
> create mode 100755 test/test-gnss
>
I applied (most) of this patch series, however see my comments for the
individual patches. I did refactor your work 'slightly', so please let
me know if something doesn't work.
Regards,
-Denis
next prev parent reply other threads:[~2011-03-28 22:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 13:46 [PATCH 00/12] Basic E911 support Jarko Poutiainen
2011-03-24 13:46 ` [PATCH 01/12] dbus: add gnss interface definition Jarko Poutiainen
2011-03-24 13:46 ` [PATCH 02/12] include: add gnss.h file Jarko Poutiainen
2011-03-24 13:46 ` [PATCH 03/12] src: add atom type for gnss Jarko Poutiainen
2011-03-24 13:46 ` [PATCH 04/12] src: add gnss atom and agent implementation Jarko Poutiainen
2011-03-24 13:46 ` [PATCH 05/12] gatchat: introduce send for +CPOS Jarko Poutiainen
2011-03-24 13:46 ` [PATCH 06/12] gatchat: new hint to handle +CPOS Jarko Poutiainen
2011-03-24 13:46 ` [PATCH 07/12] gatchat: implementation for +CPOS send Jarko Poutiainen
2011-03-28 23:00 ` Denis Kenzior
2011-03-24 13:46 ` [PATCH 08/12] gatchat: fix gatsyntax to support +CPOS Jarko Poutiainen
2011-03-24 13:46 ` [PATCH 09/12] atmodem: add gnss driver Jarko Poutiainen
2011-03-28 23:06 ` Denis Kenzior
2011-03-24 13:46 ` [PATCH 10/12] ste: add support for gnss Jarko Poutiainen
2011-03-24 13:46 ` [PATCH 11/12] ofono.conf: add positioning agent interface Jarko Poutiainen
2011-03-24 13:46 ` [PATCH 12/12] test: add test-gnss Jarko Poutiainen
2011-03-28 22:56 ` Denis Kenzior [this message]
2011-03-29 10:19 ` [PATCH 00/12] Basic E911 support Jarko Poutiainen
-- strict thread matches above, loose matches on Subject: below --
2011-03-11 12:22 [PATCH 00/12] basic " Jarko Poutiainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D91123B.8020700@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox