Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 0/9] Emergency Mode
Date: Tue, 05 Apr 2011 00:00:19 -0500	[thread overview]
Message-ID: <4D9AA1E3.9060906@gmail.com> (raw)
In-Reply-To: <1301588312-6932-1-git-send-email-jeevaka.badrappan@elektrobit.com>

[-- Attachment #1: Type: text/plain, Size: 2880 bytes --]

Hi Jeevaka,

On 03/31/2011 11:18 AM, Jeevaka Badrappan wrote:
> Hi,
> 
>  Following patch is a proposal for emergency mode. Test has been done
> with the phonesim.
> 
> Listed down few important cases to give an overview of the state
> changes that happen in each case.
> 
> Case 1: SIM Present, No PIN required, modem in offline state
> 
> 	- Modem set to online mode(UI triggered)
> 		Post online atoms created
> 	- Dial request received with emergency number
> 		- Emergency mode activated
> 		- Dial request sent to modem
> 	- Emergency call is active
> 	- Call ended
> 		Emergency mode deactivated.
> 	- Modem remains in online mode. Post online
> 	  atoms are present.
> 
> Case 2: SIM Present and PIN required
> 
> 	- Modem set to online mode(UI triggered)
> 		Post SIM and Post online atoms not created
> 	- Dial request received with emergency number
> 		- Emergency mode activated
> 		- Dial request sent to modem
> 	- Emergency call is active
> 	- Call ended
> 		Emergency mode deactivated.
> 	- Modem remains in online mode. Post sim
> 	  and post online atoms are not present/created.
> 
> Case 3: SIM Present and PIN required(Dial request cancelled by user)
> 
> 	- Modem set to online mode(UI triggered)
> 		Post SIM and Post online atoms not created
> 	- Dial request received with emergency number
> 		- Emergency mode activated
> 		- Dial request sent to modem
> 	- Dial request cancelled by user
> 		Emergency mode deactivated.
> 	- Modem remains in online mode.
> 	- User enters the right pin
> 	- Modem remains in online mode. Post sim
> 	  and post online atoms are created.
> 
> Case 4: SIM Not Present(PIN disabled SIM inserted)
> 
> 	- Modem set to online mode(UI triggered)
> 		Post SIM and Post online atoms not created
> 	- Dial request received with emergency number
> 		- Emergency mode activated
> 	- Emergency call is active
> 	- SIM inserted and SIM ready received(NO PIN required).
> 		- Post sim and post online atoms are created.
> 	- Call ended
> 		Emergency mode deactivated.
> 	- Modem remains in online mode. Post sim and post
> 	  online atoms are present.
> 
> Case 5: SIM Not Present(PIN enabled SIM inserted)
> 
> 	- Modem set to online mode(UI triggered)
> 		Post SIM and Post online atoms not created
> 	- Dial request received with emergency number
> 		- Emergency mode activated
> 	- Emergency call is active
> 	- SIM Inserted(PIN required).
> 	- Call ended
> 		Emergency mode deactivated.
> 	- Modem remains in online mode. Post sim
> 	  and post online atoms are not created.
> 

All 9 patches have been applied, in a slightly different order.  Thanks
for that!

I made some slight refactorings and additions afterward, and went ahead
and marked this task as done.  Can you take a look and see if you concur
with my changes?

Regards,
-Denis

      parent reply	other threads:[~2011-04-05  5:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-31 16:18 [RFC PATCH 0/9] Emergency Mode Jeevaka Badrappan
2011-03-31 16:18 ` [RFC PATCH 1/9] dbus: Add __ofono_error_emergency_active Jeevaka Badrappan
2011-03-31 16:18 ` [RFC PATCH 2/9] include: add ofono_modem_get_emergency_mode api Jeevaka Badrappan
2011-03-31 16:18 ` [RFC PATCH 3/9] modem: " Jeevaka Badrappan
2011-03-31 16:18 ` [RFC PATCH 4/9] modem: add Emergency property Jeevaka Badrappan
2011-03-31 16:18 ` [RFC PATCH 5/9] modem: add increment/decrement emergency mode api Jeevaka Badrappan
2011-03-31 16:18 ` [RFC PATCH 6/9] modem: modem state decoupled from rf state Jeevaka Badrappan
2011-03-31 16:18 ` [RFC PATCH 7/9] modem: restrict operations allowed in emergency Jeevaka Badrappan
2011-03-31 16:18 ` [RFC PATCH 8/9] voicecall: generalise emergency call check Jeevaka Badrappan
2011-03-31 16:18 ` [RFC PATCH 9/9] voicecall: add emergency mode handling Jeevaka Badrappan
2011-03-31 17:43 ` [RFC PATCH 0/9] Emergency Mode Marcel Holtmann
2011-03-31 22:47   ` Jeevaka.Badrappan
2011-04-05  5:00 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9AA1E3.9060906@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox