From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: PATCH H24 early support
Date: Tue, 05 Apr 2011 09:51:15 -0500 [thread overview]
Message-ID: <4D9B2C63.2000005@gmail.com> (raw)
In-Reply-To: <65D0035E6914AC478A46CFE3E20C3926017CC406@snch1xch53.sicpa-net.ads>
[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]
Hi Christophe,
On 04/05/2011 01:03 AM, Ostermann, Christophe wrote:
> Hi,
>
>
>
> I have a first working support of Motorola H24 modem. I ve tested sms /
> gprs / call.
>
> Note that for call I have not fully tested since on my device I do not
> have any microphone….
>
> If patch is not in the right format, ask me to provide it in another
> way. (I ve used quilt to generate it)
>
This is a great start. However, the patch is all mangled up, either by
your MTA or your mail server. I suggest that you use git, git
format-patch and git-send-email. It is by far the most painless (and
preferred) way to submit patches.
> ===================================================================
>
> --- ofono-0.45.orig/Makefile.in 2011-03-15 15:11:23.000000000 +0100
>
> +++ ofono-0.45/Makefile.in 2011-04-04 15:00:52.806400966 +0200
>
Please note that this file is not part of the git repository, you really
want Makefile.am. Makefile.in is generated by the build system.
Regards,
-Denis
prev parent reply other threads:[~2011-04-05 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 6:03 PATCH H24 early support Ostermann, Christophe
2011-04-05 14:51 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9B2C63.2000005@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox