Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 4/6] stkutil.c: Send at least the data currently available
Date: Mon, 11 Apr 2011 23:40:26 -0500	[thread overview]
Message-ID: <4DA3D7BA.4050001@gmail.com> (raw)
In-Reply-To: <1302280411-20762-4-git-send-email-philippe.nunes@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

Hi Philippe,

On 04/08/2011 11:33 AM, Philippe Nunes wrote:
> ---
>  src/stkutil.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/stkutil.c b/src/stkutil.c
> index 7299fb5..ee59841 100644
> --- a/src/stkutil.c
> +++ b/src/stkutil.c
> @@ -5655,7 +5655,8 @@ static gboolean build_receive_data(struct stk_tlv_builder *builder,
>  	const struct stk_response_receive_data *receive_data =
>  		&response->receive_data;
>  
> -	if (response->result.type != STK_RESULT_TYPE_SUCCESS)
> +	if (response->result.type != STK_RESULT_TYPE_SUCCESS &&
> +			response->result.type != STK_RESULT_TYPE_MISSING_INFO)
>  		return TRUE;
>  
>  	if (receive_data->rx_data.len) {

Does this check also belong on other data object builders?

Regards,
-Denis

  reply	other threads:[~2011-04-12  4:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 16:33 [PATCH 4/6] stkutil.c: Send at least the data currently available Philippe Nunes
2011-04-12  4:40 ` Denis Kenzior [this message]
2011-04-13  9:54   ` Philippe Nunes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA3D7BA.4050001@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox