From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 0/6] phonesim: Add call status UI
Date: Mon, 02 May 2011 04:23:51 -0500 [thread overview]
Message-ID: <4DBE7827.8030901@gmail.com> (raw)
In-Reply-To: <1304327838-11164-1-git-send-email-nicolas.bertrand@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]
Hi Nicolas,
On 05/02/2011 04:17 AM, Nicolas Bertrand wrote:
> This patch introduce a new tab "call" in phonesim UI in order to display calls
> informationsi (id, number, status, name and direction).
> The interface to send CSSU and CSSI notification is now dynamic based on the
> type of current calls.
> Fix some coding-style violations.
>
> Nicolas Bertrand (6):
> callmanager: Add signal on call status change
> control: Update UI using call status
> hardwaremanipulator: add callmanagement method
> phonesim: Connect call status signal
> controlbase.ui: Add call mangement tab
> control: Update call view
>
> src/callmanager.cpp | 22 +++++++
> src/callmanager.h | 3 +
> src/control.cpp | 140 ++++++++++++++++++++++++++++++++++++++-----
> src/control.h | 6 ++
> src/controlbase.ui | 61 +++++++++++++++++++
> src/hardwaremanipulator.cpp | 4 +
> src/hardwaremanipulator.h | 2 +
> src/phonesim.cpp | 2 +
> 8 files changed, 224 insertions(+), 16 deletions(-)
I applied all of the patches in this series, thanks.
Some general comments:
Your logic for enabling CSSI/CSSU buttons is not really correct. CSSU
notifications (2, 3, 4) can come at any time there is an active/held
call, and not just during MT call setup.
You might also want to move the CSSI/CSSU generator UI elements into the
Call tab. They logically belong there now.
Regards,
-Denis
prev parent reply other threads:[~2011-05-02 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 9:17 [PATCH v2 0/6] phonesim: Add call status UI Nicolas Bertrand
2011-05-02 9:17 ` [PATCH v2 1/6] callmanager: Add signal on call status change Nicolas Bertrand
2011-05-02 9:17 ` [PATCH v2 2/6] control: Update UI using call status Nicolas Bertrand
2011-05-02 9:17 ` [PATCH v2 3/6] hardwaremanipulator: add callmanagement method Nicolas Bertrand
2011-05-02 9:17 ` [PATCH v2 4/6] phonesim: Connect call status signal Nicolas Bertrand
2011-05-02 9:17 ` [PATCH v2 5/6] controlbase.ui: Add call mangement tab Nicolas Bertrand
2011-05-02 9:17 ` [PATCH v2 6/6] control: Update call view Nicolas Bertrand
2011-05-02 9:23 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBE7827.8030901@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox