Re: [PATCH 1/4] voicecall: create generic dial function

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

Hi Frédéric,

On 05/12/2011 09:40 AM, Frédéric Danis wrote:
> split manager_dial between generic and dbus parts
> ---
>  src/voicecall.c |  106 +++++++++++++++++++++++++++++++++++++++++--------------
>  1 files changed, 79 insertions(+), 27 deletions(-)
> 
> diff --git a/src/voicecall.c b/src/voicecall.c
> index d46f463..037caac 100644
> --- a/src/voicecall.c
> +++ b/src/voicecall.c
> @@ -42,6 +42,17 @@
>  
>  #define VOICECALL_FLAG_SIM_ECC_READY 0x1
>  
> +enum dial_error {
> +	DIAL_NO_ERROR,
> +	DIAL_TOO_MANY_CALLS,
> +	DIAL_INVALID_PHONE,
> +	DIAL_NO_NETWORK,
> +	DIAL_NOT_SUPPORTED,
> +	DIAL_INCOMING,
> +	DIAL_BUSY,
> +	DIAL_ACTIVE
> +};
> +

Lets try to re-use errno.h for this.

e.g. NO_ERROR -> 0

TOO_MANY_CALLS -> -EPERM

INVALID_PHONE -> -EINVAL

NO_NETWORK -> -ENETDOWN

NOT_SUPPORTED -> -ENOTSUP

INCOMING, BUSY, ACTIVE -> -EBUSY or -EPERM

Regards,
-Denis