From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH V2 3/4] voicecall: save last dialed number
Date: Wed, 25 May 2011 06:19:50 -0500 [thread overview]
Message-ID: <4DDCE5D6.5060708@gmail.com> (raw)
In-Reply-To: <1305884461-4476-4-git-send-email-frederic.danis@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
Hi Frédéric,
<snip>
>
> +#define VOICECALL_STORE "voicecall"
Can you please be consistent with the rest of the code and name this
SETTINGS_STORE?
> +#define LASTDIAL_GROUP "LastDial"
> +
Same here, call this SETTINGS_GROUP and use "Settings"
Regards,
-Denis
next prev parent reply other threads:[~2011-05-25 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 9:40 [PATCH V2 0/4] Add dial support for HFP emulator =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2011-05-20 9:40 ` [PATCH V2 1/4] voicecall: create generic dial function =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2011-05-25 10:59 ` Denis Kenzior
2011-05-20 9:40 ` [PATCH V2 2/4] voicecall: add ATD support for HFP emulator =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2011-05-25 11:16 ` Denis Kenzior
2011-05-20 9:41 ` [PATCH V2 3/4] voicecall: save last dialed number =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2011-05-25 11:19 ` Denis Kenzior [this message]
2011-05-20 9:41 ` [PATCH V2 4/4] voicecall: add +BLDN support for HFP emulator =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDCE5D6.5060708@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox