From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] udev: changed linktop device strings
Date: Sat, 11 Jun 2011 09:05:27 -0500 [thread overview]
Message-ID: <4DF37627.2080404@gmail.com> (raw)
In-Reply-To: <1307526380-6285-2-git-send-email-mendapara.amit@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
Hi Amit,
On 06/08/2011 04:46 AM, Amit Mendapara wrote:
> Signed-off-by: Amit Mendapara <mendapara.amit@gmail.com>
> ---
> plugins/udev.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
Please remove the Signed-off-by line as we don't use it.
> diff --git a/plugins/udev.c b/plugins/udev.c
> index 0234fc0..4f4e6d8 100644
> --- a/plugins/udev.c
> +++ b/plugins/udev.c
> @@ -577,10 +577,10 @@ static void add_linktop(struct ofono_modem *modem,
>
> if (g_strcmp0(intfnum, "01") == 0) {
> devnode = udev_device_get_devnode(udev_device);
> - ofono_modem_set_string(modem, "Modem", devnode);
> + ofono_modem_set_string(modem, "ModemDevice", devnode);
> } else if (g_strcmp0(intfnum, "03") == 0) {
> devnode = udev_device_get_devnode(udev_device);
> - ofono_modem_set_string(modem, "Control", devnode);
> + ofono_modem_set_string(modem, "DataDevice", devnode);
>
> ofono_modem_set_integer(modem, "Registered", 1);
> ofono_modem_register(modem);
Rest looks fine to me.
Regards,
-Denis
next prev parent reply other threads:[~2011-06-11 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 9:46 [PATCH 1/2] linktop: reimplemented linktop plugin based on mbm Amit Mendapara
2011-06-08 9:46 ` [PATCH 2/2] udev: changed linktop device strings Amit Mendapara
2011-06-11 14:05 ` Denis Kenzior [this message]
2011-06-11 14:03 ` [PATCH 1/2] linktop: reimplemented linktop plugin based on mbm Denis Kenzior
2011-06-13 7:30 ` Amit Mendapara
2011-06-12 8:57 ` Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2011-06-27 6:22 [PATCH 1/2] linktop: reimplemented with minimum features Amit Mendapara
2011-06-27 6:22 ` [PATCH 2/2] udev: changed linktop device strings Amit Mendapara
2011-06-27 15:35 ` Denis Kenzior
2011-06-20 7:35 [PATCH 1/2] linktop: reimplemented linktop plugin with minimum features Amit Mendapara
2011-06-20 7:35 ` [PATCH 2/2] udev: changed linktop device strings Amit Mendapara
2011-06-15 7:13 [PATCH 1/2] linktop: reimplemented linktop plugin based on mbm with minimum features Amit Mendapara
2011-06-15 7:13 ` [PATCH 2/2] udev: changed linktop device strings Amit Mendapara
2011-04-14 10:13 [PATCH 1/2] linktop: reimplemented linktop plugin based on mbm Amit Mendapara
2011-04-14 10:13 ` [PATCH 2/2] udev: changed linktop device strings Amit Mendapara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF37627.2080404@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox