Re: [PATCH 1/3] message-waiting: add API to retrieve voicemail number

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

Hi Frédéric,

On 06/20/2011 10:12 AM, Frédéric Danis wrote:
> ---
>  include/message-waiting.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/message-waiting.h b/include/message-waiting.h
> index b40993e..adb7ef2 100644
> --- a/include/message-waiting.h
> +++ b/include/message-waiting.h
> @@ -33,6 +33,8 @@ struct ofono_message_waiting;
>  struct ofono_message_waiting *ofono_message_waiting_create(struct ofono_modem *modem);
>  void ofono_message_waiting_register(struct ofono_message_waiting *mw);
>  void ofono_message_waiting_remove(struct ofono_message_waiting *mw);
> +const struct ofono_phone_number *ofono_message_waiting_get_voicemail_number(
> +					struct ofono_message_waiting *mw);

I'd like to keep this API private for now, so lets move this to ofono.h
and combine patch 1 & 2 together.

Also, can you please use the following signature:

const struct ofono_phone_number *__ofono_message_waiting_get_mbdn(
					struct ofono_message_waiting *mw, unsigned int index);

Regards,
-Denis