Re: [PATCH 3/3] bluetooth: fix not removing data when devices/adapters are removed

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

Hi Luiz,

On 07/01/2011 02:12 AM, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> If an adapter or device is removed any data associate should be removed,
> otherwise the next time they appear/are created the drivers may not
> asssociate again.
> ---
>  plugins/bluetooth.c |   79 ++++++++++++++++++++++++++++++++++++--------------
>  plugins/bluetooth.h |    4 +-
>  plugins/hfp_hf.c    |   30 ++++++++++++-------
>  3 files changed, 78 insertions(+), 35 deletions(-)

Patch looks good, just one quick question:

> @@ -443,25 +443,33 @@ free:
>  	return -ENOMEM;
>  }
>  
> -static gboolean hfp_remove_each_modem(gpointer key, gpointer value,
> +static gboolean hfp_remove_modem(gpointer key, gpointer value,
>  					gpointer user_data)
>  {
>  	struct ofono_modem *modem = value;
> +	const char *device = key;
> +	const char *prefix = user_data;
> +
> +	if (prefix && g_str_has_prefix(device, prefix) == FALSE)
> +		return TRUE;

Are you sure you want to return TRUE here?  By my reading TRUE should be
removed only if the key should be removed.  That seems not to be what
you want...

>  
>  	ofono_modem_remove(modem);
>  
>  	return TRUE;
>  }
>  

Regards,
-Denis