From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/4] include: Add driver api for user confirmation
Date: Wed, 06 Jul 2011 01:28:35 -0500 [thread overview]
Message-ID: <4E140093.3080607@gmail.com> (raw)
In-Reply-To: <1309946773-7747-2-git-send-email-jeevaka.badrappan@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
Hi Jeevaka,
On 07/06/2011 05:06 AM, Jeevaka Badrappan wrote:
> ---
> include/stk.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/stk.h b/include/stk.h
> index c276c84..9a63917 100644
> --- a/include/stk.h
> +++ b/include/stk.h
> @@ -47,6 +47,7 @@ struct ofono_stk_driver {
> void (*terminal_response)(struct ofono_stk *stk,
> int length, const unsigned char *resp,
> ofono_stk_generic_cb_t cb, void *data);
> + void (*user_confirmation)(struct ofono_stk *stk, gboolean confirm);
Please don't use glib types in public API. Use ofono_bool_t here instead.
> };
>
> int ofono_stk_driver_register(const struct ofono_stk_driver *d);
Regards,
-Denis
next prev parent reply other threads:[~2011-07-06 6:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 10:06 [PATCH 0/4] Add support for modem handled setup call proactive command Jeevaka Badrappan
2011-07-06 10:06 ` [PATCH 1/4] include: Add driver api for user confirmation Jeevaka Badrappan
2011-07-06 6:28 ` Denis Kenzior [this message]
2011-07-06 10:06 ` [PATCH 2/4] voicecall: api for set/clear alpha and icon id Jeevaka Badrappan
2011-07-06 6:38 ` Denis Kenzior
2011-07-06 10:06 ` [PATCH 3/4] stk: Handle set up call in handled_notify Jeevaka Badrappan
2011-07-06 6:43 ` Denis Kenzior
2011-07-06 16:51 ` Andrzej Zaborowski
2011-07-06 10:06 ` [PATCH 4/4] ifxmodem: add support for user_confirmation in stk Jeevaka Badrappan
-- strict thread matches above, loose matches on Subject: below --
2011-07-15 12:42 [PATCH 0/4] Add support for modem handled setup call proactive command Jeevaka Badrappan
2011-07-15 12:42 ` [PATCH 1/4] include: Add driver api for user confirmation Jeevaka Badrappan
2011-07-15 16:10 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E140093.3080607@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox