Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC 2/3] bluetooth: Add UUID for DUN.
Date: Thu, 07 Jul 2011 03:00:36 -0500	[thread overview]
Message-ID: <4E1567A4.3050308@gmail.com> (raw)
In-Reply-To: <1310028323-29180-3-git-send-email-mario@tokarz.eu>

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

Hi Mario,

On 07/07/2011 03:45 AM, Mario Tokarz wrote:
> From: Mario Tokarz <mario.tokarz@bmw-carit.de>
> 
> ---
>  plugins/bluetooth.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/plugins/bluetooth.h b/plugins/bluetooth.h
> index 7f9f810..f572e5d 100644
> --- a/plugins/bluetooth.h
> +++ b/plugins/bluetooth.h
> @@ -27,9 +27,11 @@
>  
>  #define DBUS_TIMEOUT 15
>  
> +#define DUN_GW_UUID	"00001103-0000-1000-8000-00805f9b34fb"
>  #define HFP_AG_UUID	"0000111f-0000-1000-8000-00805f9b34fb"
>  #define HFP_HS_UUID	"0000111e-0000-1000-8000-00805f9b34fb"
>  
> +

Why this empty line?

>  struct bluetooth_profile {
>  	const char *name;
>  	int (*probe)(const char *device, const char *dev_addr,

Regards,
-Denis

  reply	other threads:[~2011-07-07  8:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07  8:45 [RFC 0/3] Adding DUN support Mario Tokarz
2011-07-07  8:45 ` [RFC 1/3] dunmodem: Add baseline for DUN modem driver Mario Tokarz
2011-07-07  8:16   ` Denis Kenzior
2011-07-07  8:45 ` [RFC 2/3] bluetooth: Add UUID for DUN Mario Tokarz
2011-07-07  8:00   ` Denis Kenzior [this message]
2011-07-07  8:45 ` [RFC 3/3] dun_dt: Add baseline for dun_dt plug-in Mario Tokarz
2011-07-07 16:59   ` Gustavo Padovan
2011-07-10 21:07     ` Mario Tokarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1567A4.3050308@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox