From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v4 0/2] Add support for modem handled setup call proactive command
Date: Mon, 25 Jul 2011 23:00:16 -0500 [thread overview]
Message-ID: <4E2E3BD0.3010402@gmail.com> (raw)
In-Reply-To: <1311617727-10294-1-git-send-email-jeevaka.badrappan@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
Hi Jeevaka,
On 07/25/2011 01:15 PM, Jeevaka Badrappan wrote:
> Hi,
>
> This patch set fixes the review comments.
>
> If the modem is able to setup the call, then the alpha id will be freed when the
> initiated call ends.
>
> If the modem is not able to setup the call due to some reason, then the memory
> allocated for alpha id and dial request are freed when the command end/session
> end is received.
>
I went ahead and applied both of these patches. I did do some minor
refactoring afterwards, please test and let me know whether I broke
something.
> Also, noticed there is a break missing in the ofono_stk_proactive_command_handled_notify
> for STK_COMMAND_TYPE_SEND_SS case. Fix for that will be provided as a separate patch.
I went ahead and fixed this as well.
>
> Note: This version of the patch is not tested.
>
> Thanks and Regards,
> Jeevaka
>
Regards,
-Denis
prev parent reply other threads:[~2011-07-26 4:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 18:15 [PATCH v4 0/2] Add support for modem handled setup call proactive command Jeevaka Badrappan
2011-07-25 18:15 ` [PATCH v4 1/2] voicecall: api for set/clear alpha and icon id Jeevaka Badrappan
2011-07-25 18:15 ` [PATCH v4 2/2] stk: Handle set up call in handled_notify Jeevaka Badrappan
2011-07-26 4:00 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2E3BD0.3010402@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox