From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH_v6 06/14] huaweicdmamodem: create a huawei cdma driver.
Date: Fri, 05 Aug 2011 10:54:04 -0500 [thread overview]
Message-ID: <4E3C121C.6070705@gmail.com> (raw)
In-Reply-To: <1312550475-8537-7-git-send-email-bertrand.aygon@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1783 bytes --]
Hi Bertrand,
On 08/05/2011 08:21 AM, Bertrand Aygon wrote:
> ---
> Makefile.am | 5 +++
> drivers/huaweicdmamodem/huaweicdmamodem.c | 42 +++++++++++++++++++++++++++++
> drivers/huaweicdmamodem/huaweicdmamodem.h | 21 ++++++++++++++
> 3 files changed, 68 insertions(+), 0 deletions(-)
> create mode 100644 drivers/huaweicdmamodem/huaweicdmamodem.c
> create mode 100644 drivers/huaweicdmamodem/huaweicdmamodem.h
>
Patch has been applied, however:
<snip>
> diff --git a/drivers/huaweicdmamodem/huaweicdmamodem.h b/drivers/huaweicdmamodem/huaweicdmamodem.h
> new file mode 100644
> index 0000000..018747f
> --- /dev/null
> +++ b/drivers/huaweicdmamodem/huaweicdmamodem.h
> @@ -0,0 +1,21 @@
> +/*
> + *
> + * oFono - Open Source Telephony
> + *
> + * Copyright (C) 2008-2011 Intel Corporation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> + *
> + */
> +
I had to take out this empty line otherwise git am complained. This
causes git am of patches 7, 8, 11 to fail. So please resubmit these.
Regards,
-Denis
next prev parent reply other threads:[~2011-08-05 15:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 13:21 [PATCH_v6 00/14] Create CDMA netreg atom Bertrand Aygon
2011-08-05 13:21 ` [PATCH_v6 01/14] cdmamodem: define " Bertrand Aygon
2011-08-05 15:50 ` Denis Kenzior
2011-08-05 13:21 ` [PATCH_v6 02/14] cdmamodem: create include file for CDMA netreg Bertrand Aygon
2011-08-05 15:51 ` Denis Kenzior
2011-08-05 13:21 ` [PATCH_v6 03/14] cdmamodem: create the interface " Bertrand Aygon
2011-08-05 15:51 ` Denis Kenzior
2011-08-05 13:21 ` [PATCH_v6 04/14] cdmamodem: define cdma network status Bertrand Aygon
2011-08-05 15:52 ` Denis Kenzior
2011-08-05 13:21 ` [PATCH_v6 05/14] cdmamodem: implement " Bertrand Aygon
2011-08-05 15:52 ` Denis Kenzior
2011-08-05 13:21 ` [PATCH_v6 06/14] huaweicdmamodem: create a huawei cdma driver Bertrand Aygon
2011-08-05 15:54 ` Denis Kenzior [this message]
2011-08-05 13:21 ` [PATCH_v6 07/14] huaweicdma: create a dedicated netreg atom Bertrand Aygon
2011-08-05 16:04 ` Denis Kenzior
2011-08-05 13:21 ` [PATCH_v6 08/14] huaweicdma: register to CDMA " Bertrand Aygon
2011-08-05 13:21 ` [PATCH_v6 09/14] cdmamodem: add strength " Bertrand Aygon
2011-08-05 15:54 ` Denis Kenzior
2011-08-05 13:21 ` [PATCH_v6 10/14] " Bertrand Aygon
2011-08-05 15:54 ` Denis Kenzior
2011-08-05 13:21 ` [PATCH_v6 11/14] huaweicdma: register to ^RSSILVL to update signal strength Bertrand Aygon
2011-08-05 13:21 ` [PATCH_v6 12/14] cdmamodem: add data strength to CDMA netreg atom Bertrand Aygon
2011-08-05 15:55 ` Denis Kenzior
2011-08-05 13:21 ` [PATCH_v6 13/14] " Bertrand Aygon
2011-08-05 15:56 ` Denis Kenzior
2011-08-05 13:21 ` [PATCH_v6 14/14] test: update list-modem to display CDMA DataStrength info Bertrand Aygon
2011-08-05 15:56 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3C121C.6070705@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox