From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 06/12] hfpmodem: Support for +BSIR unsol. result codes
Date: Fri, 09 Sep 2011 00:48:50 -0500 [thread overview]
Message-ID: <4E69A8C2.6060408@gmail.com> (raw)
In-Reply-To: <1316104483-13144-7-git-send-email-mikel.astiz@bmw-carit.de>
[-- Attachment #1: Type: text/plain, Size: 1753 bytes --]
Hi Mikel,
On 09/15/2011 11:34 AM, Mikel Astiz wrote:
> ---
> drivers/hfpmodem/handsfree.c | 17 +++++++++++++++++
> 1 files changed, 17 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hfpmodem/handsfree.c b/drivers/hfpmodem/handsfree.c
> index 9b7b986..a3e7978 100644
> --- a/drivers/hfpmodem/handsfree.c
> +++ b/drivers/hfpmodem/handsfree.c
> @@ -43,6 +43,7 @@
>
> struct hf_data {
> GAtChat *chat;
> + unsigned int vendor;
If you're not planning to use the vendor member for anything then it is
better left out.
> };
>
> static gboolean hfp_handsfree_register(gpointer user_data)
> @@ -54,6 +55,19 @@ static gboolean hfp_handsfree_register(gpointer user_data)
> return FALSE;
> }
>
> +static void bsir_notify(GAtResult *result, gpointer user_data)
> +{
> + struct ofono_handsfree *hf = user_data;
> + struct hf_data *hd = ofono_handsfree_get_data(hf);
> + int value;
> +
> + if (at_util_parse_reg_unsolicited(result, "+BSIR:", &value,
> + NULL, NULL, NULL, hd->vendor) == FALSE)
> + return;
> +
> + ofono_handsfree_set_inband_ringing(hf, (ofono_bool_t) value);
> +}
> +
> static int hfp_handsfree_probe(struct ofono_handsfree *hf,
> unsigned int vendor, void *data)
> {
> @@ -63,9 +77,12 @@ static int hfp_handsfree_probe(struct ofono_handsfree *hf,
> DBG("");
> hd = g_new0(struct hf_data, 1);
> hd->chat = g_at_chat_clone(info->chat);
> + hd->vendor = vendor;
>
> ofono_handsfree_set_data(hf, hd);
>
> + g_at_chat_register(hd->chat, "+BSIR:", bsir_notify, FALSE, hf, NULL);
> +
Just a minor nitpick, but I'd like this to be done in hfp_handsfree_register
> g_idle_add(hfp_handsfree_register, hf);
>
> return 0;
Regards,
-Denis
next prev parent reply other threads:[~2011-09-09 5:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 16:34 [PATCH 00/12] Bluetooth HFP-specific extensions Mikel Astiz
2011-09-15 16:34 ` [PATCH 01/12] TODO: Task added for HFP-specific capabilities Mikel Astiz
2011-09-09 5:10 ` Denis Kenzior
2011-09-15 16:34 ` [PATCH 02/12] Add handsfree atom " Mikel Astiz
2011-09-09 5:13 ` Denis Kenzior
2011-09-16 15:56 ` Daniel Wagner
2011-09-09 5:14 ` Denis Kenzior
2011-09-15 16:34 ` [PATCH 03/12] hfpmodem: Driver implements handsfree atom Mikel Astiz
2011-09-09 6:14 ` Denis Kenzior
2011-09-15 16:34 ` [PATCH 04/12] hfp_hf: Plugin creates " Mikel Astiz
2011-09-09 6:16 ` Denis Kenzior
2011-09-15 16:34 ` [PATCH 05/12] handsfree: Atom supports inband ringing status Mikel Astiz
2011-09-09 6:15 ` Denis Kenzior
2011-09-15 16:34 ` [PATCH 06/12] hfpmodem: Support for +BSIR unsol. result codes Mikel Astiz
2011-09-09 5:48 ` Denis Kenzior [this message]
2011-09-15 16:34 ` [PATCH 07/12] handsfree: Support for number requests (AT+BINP=1) Mikel Astiz
2011-09-09 6:16 ` Denis Kenzior
2011-09-15 16:34 ` [PATCH 08/12] handsfree: Expose RequestInput in D-Bus API Mikel Astiz
2011-09-09 6:01 ` Denis Kenzior
2011-09-15 16:34 ` [PATCH 09/12] hfpmodem: Support of number requests (AT+BINP=1) Mikel Astiz
2011-09-09 6:04 ` Denis Kenzior
2011-09-15 16:34 ` [PATCH 10/12] handsfree: Read-only voice-recognition D-Bus prop Mikel Astiz
2011-09-09 6:13 ` Denis Kenzior
2011-09-15 16:34 ` [PATCH 11/12] handsfree: Writable voice-recogn. prop (AT+BVRA) Mikel Astiz
2011-09-15 16:34 ` [PATCH 12/12] hfpmodem: Support for AT+BVRA Mikel Astiz
2011-09-09 6:17 ` Denis Kenzior
2011-09-23 8:57 ` [PATCH 00/12] Bluetooth HFP-specific extensions =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E69A8C2.6060408@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox