Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCHv7 3/3] plugins: Add provisioning plugin
Date: Thu, 29 Sep 2011 09:03:37 -0500	[thread overview]
Message-ID: <4E847AB9.6000407@gmail.com> (raw)
In-Reply-To: <4E8458D4.7030506@intel.com>

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

Hi Oleg,

On 09/29/2011 06:39 AM, Oleg Zhurakivskyy wrote:
> Hello Denis,
> 
> On 09/28/2011 07:22 AM, Denis Kenzior wrote:
>> Please don't copy paste the contents of plugins/mbpi.c.  The intent is
>> to just re-use that code, similar to how tools/lookup-apn.c works.  If
>> you want to make any improvements to plugins/mbpi.c, then submit a
>> separate patch against that file.
> 
> I must have misunderstood the intent then. Just to make sure there's no
> further misunderstanding on this, so the plugin plugins/provision.c
> would use the parser plugins/mpbi.c?

Correct.

Regards,
-Denis

      reply	other threads:[~2011-09-29 14:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23 11:41 [PATCHv7 0/3] Provisioning plugin Oleg Zhurakivskyy
2011-09-23 11:41 ` [PATCHv7 1/3] plugins: Provisioning plugin autoconf support Oleg Zhurakivskyy
2011-09-23 11:41 ` [PATCHv7 2/3] plugins: Provisioning plugin makefile changes Oleg Zhurakivskyy
2011-09-23 11:41 ` [PATCHv7 3/3] plugins: Add provisioning plugin Oleg Zhurakivskyy
2011-09-28  4:22   ` Denis Kenzior
2011-09-29 11:39     ` Oleg Zhurakivskyy
2011-09-29 14:03       ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E847AB9.6000407@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox