Re: [PATCHv8 4/6] plugins: mobile-broadband-provider-info parser changes

[Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]

Hello Denis,

On 10/04/2011 05:05 PM, Denis Kenzior wrote:
> While you're strictly right, in practice this is not something to worry
> about.  Our convention is to ignore the possibility of failure on small
> allocations, these can't really happen on Linux anyway.  The OOM killer
> will kill something before that happens, likely a system daemon that is
> even more important than oFono ;)
>
> As a rule of thumb the only time you should worry about memory
> allocations is when you're allocating more than a few pages worth of
> memory.

OK. Thanks for the clarification, I will follow this approach.

>> In case there are multiple "name", "username", "password" entries per
>> APN. In theory this can't happen with the proper validation of the
>> database, in practice users can edit it manually and use without the
>> validation, which would result in the memory leak. Does this make sense?
>
> I don't think it does, no user should be able to edit the provisioning
> database.  oFono is running as root and expects this to be readable by
> root only.  If you really want to handle this case then returning an
> error (since that is what it is) would be way better.

OK, let's stick to the original approach here.

Regards,
Oleg
-- 
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki