From: Mikel Astiz <mikel.astiz@bmw-carit.de>
To: ofono@ofono.org
Subject: Re: AT commands not being parsed correctly from Samsung Wave HFP
Date: Fri, 07 Oct 2011 12:57:17 +0200 [thread overview]
Message-ID: <4E8EDB0D.9020304@bmw-carit.de> (raw)
In-Reply-To: <4E8DED34.5030906@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
Hi Denis,
On 10/06/2011 08:02 PM, Denis Kenzior wrote:
> Hi Mikel,
>
>> ofonod[12078]:> AT+CLCC\r
>> ofonod[12078]:< \r\n\r\nOK\r\n\r\n
>>
>>
> There is an extra set of \r\n at the end of the OK and the gsmv1 syntax
> parser used by the hfp_hf plugin is quite strict.
>
>> It seems that, after the last line, no other AT commands are parsed
>> correctly. Any ideas of what's wrong?
> Try using the permissive syntax parser.
>
> Regards,
> -Denis
Right, the permissive one works perfectly. The phone has passed all our
tests.
Now the next question is whether it would make sense to switch the HFP
plugin to this parser, or this would rather be done selectively.
Which would be the drawbacks of using the permissive parser for all phones?
Regards,
Mikel
next prev parent reply other threads:[~2011-10-07 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 17:45 AT commands not being parsed correctly from Samsung Wave HFP Mikel Astiz
2011-10-06 18:02 ` Denis Kenzior
2011-10-07 10:57 ` Mikel Astiz [this message]
2011-10-07 13:33 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8EDB0D.9020304@bmw-carit.de \
--to=mikel.astiz@bmw-carit.de \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox