From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCHv10 1/9] mbpi: Minor style tweaks
Date: Thu, 20 Oct 2011 12:50:18 -0500 [thread overview]
Message-ID: <4EA05F5A.4050802@gmail.com> (raw)
In-Reply-To: <1318935905-9087-2-git-send-email-oleg.zhurakivskyy@intel.com>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
Hi Oleg,
On 10/18/2011 06:04 AM, Oleg Zhurakivskyy wrote:
> ---
> plugins/mbpi.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/plugins/mbpi.c b/plugins/mbpi.c
> index ecb08eb..c5537d8 100644
> --- a/plugins/mbpi.c
> +++ b/plugins/mbpi.c
> @@ -23,12 +23,13 @@
> #include <config.h>
> #endif
>
> -#include <string.h>
> -#include <fcntl.h>
> +#include <sys/types.h>
> #include <sys/mman.h>
> #include <sys/stat.h>
> -#include <sys/types.h>
> +
> +#include <fcntl.h>
> #include <errno.h>
> +#include <string.h>
> #include <unistd.h>
>
> #include <glib.h>
I decided to drop this patch since we really have no rule to separate
sys/ includes from regular ones. The current style is fine.
Regards,
-Denis
next prev parent reply other threads:[~2011-10-20 17:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 11:04 [PATCHv10 0/9] Provisioning plugin Oleg Zhurakivskyy
2011-10-18 11:04 ` [PATCHv10 1/9] mbpi: Minor style tweaks Oleg Zhurakivskyy
2011-10-20 17:50 ` Denis Kenzior [this message]
2011-10-18 11:04 ` [PATCHv10 2/9] provision: Add provisioning plugin Oleg Zhurakivskyy
2011-10-20 17:51 ` Denis Kenzior
2011-10-18 11:04 ` [PATCHv10 3/9] mbpi: Add mbpi_ap_type() Oleg Zhurakivskyy
2011-10-20 17:51 ` Denis Kenzior
2011-10-18 11:05 ` [PATCHv10 4/9] lookup-apn: Use mbpi_ap_type() Oleg Zhurakivskyy
2011-10-18 11:05 ` [PATCHv10 5/9] lookup-apn: Add command line option to control duplicates Oleg Zhurakivskyy
2011-10-18 11:05 ` [PATCHv10 6/9] mbpi: Rename mbpi_provision_data_free() Oleg Zhurakivskyy
2011-10-18 11:05 ` [PATCHv10 7/9] lookup-apn: Use mbpi_ap_free() Oleg Zhurakivskyy
2011-10-18 11:05 ` [PATCHv10 8/9] mbpi: Minor style issues Oleg Zhurakivskyy
2011-10-18 11:05 ` [PATCHv10 9/9] lookup-apn: " Oleg Zhurakivskyy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA05F5A.4050802@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox