From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v4 12/12] hfp_hf: BT address exposed through Serial property
Date: Fri, 21 Oct 2011 14:33:27 -0500 [thread overview]
Message-ID: <4EA1C907.7040800@gmail.com> (raw)
In-Reply-To: <1319215897-6310-13-git-send-email-mikel.astiz@bmw-carit.de>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
Hi Mikel,
On 10/21/2011 11:51 AM, Mikel Astiz wrote:
> ---
> plugins/hfp_hf.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/plugins/hfp_hf.c b/plugins/hfp_hf.c
> index ba06434..c9451d2 100644
> --- a/plugins/hfp_hf.c
> +++ b/plugins/hfp_hf.c
> @@ -38,6 +38,7 @@
> #include <ofono/plugin.h>
> #include <ofono/log.h>
> #include <ofono/modem.h>
> +#include <ofono/devinfo.h>
> #include <ofono/netreg.h>
> #include <ofono/voicecall.h>
> #include <ofono/call-volume.h>
> @@ -232,6 +233,9 @@ static int hfp_hf_probe(const char *device, const char *dev_addr,
>
> ofono_modem_set_data(modem, data);
> ofono_modem_set_name(modem, alias);
> +
> + ofono_devinfo_create(modem, 0, "hfpmodem", (void *) dev_addr);
> +
Why is this being done in probe and not pre_sim?
> ofono_modem_register(modem);
>
> g_hash_table_insert(modem_hash, g_strdup(device), modem);
Regards,
-Denis
next prev parent reply other threads:[~2011-10-21 19:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 16:51 [PATCH v4 00/12] Bluetooth HFP-specific extensions Mikel Astiz
2011-10-21 16:51 ` [PATCH v4 01/12] include: Voice recognition in handsfree public api Mikel Astiz
2011-10-21 16:51 ` [PATCH v4 02/12] handsfree: Implement voice recognition function Mikel Astiz
2011-10-21 16:51 ` [PATCH v4 03/12] hfpmodem: Support for AT+BVRA Mikel Astiz
2011-10-21 16:51 ` [PATCH v4 04/12] doc: Handsfree exposes supported AG features Mikel Astiz
2011-10-21 16:51 ` [PATCH v4 05/12] handsfree: Supported AG features exposed in D-Bus Mikel Astiz
2011-10-21 19:32 ` Denis Kenzior
2011-10-21 16:51 ` [PATCH v4 06/12] hfpmodem: Report features supported by AG Mikel Astiz
2011-10-21 16:51 ` [PATCH v4 07/12] hfpmodem: Avoid segfault in network-registration Mikel Astiz
2011-10-21 16:51 ` [PATCH v4 08/12] hfpmodem: Avoid segfault in call-volume Mikel Astiz
2011-10-21 16:51 ` [PATCH v4 09/12] hfpmodem: Avoid segfault in handsfree Mikel Astiz
2011-10-21 16:51 ` [PATCH v4 10/12] devinfo: avoid crash if query_model not supported Mikel Astiz
2011-10-21 16:51 ` [PATCH v4 11/12] hfpmodem: devinfo atom added to export BT address Mikel Astiz
2011-10-21 16:51 ` [PATCH v4 12/12] hfp_hf: BT address exposed through Serial property Mikel Astiz
2011-10-21 19:33 ` Denis Kenzior [this message]
2011-10-21 19:30 ` [PATCH v4 00/12] Bluetooth HFP-specific extensions Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA1C907.7040800@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox