Re: [PATCH_v2 5/6] cdma-connman: Add public api definition

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

Hi Guillaume,

On 11/02/2011 05:38 AM, Guillaume Zajac wrote:
> ---
>  src/cdma-connman.c |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
> 
> diff --git a/src/cdma-connman.c b/src/cdma-connman.c
> index 42dcca2..f88353a 100644
> --- a/src/cdma-connman.c
> +++ b/src/cdma-connman.c
> @@ -562,6 +562,24 @@ void ofono_cdma_connman_driver_unregister(
>  	g_drivers = g_slist_remove(g_drivers, (void *) d);
>  }
>  
> +void ofono_cdma_connman_deactivated(struct ofono_cdma_connman *cm)
> +{
> +	DBusConnection *conn = ofono_dbus_get_connection();
> +	const char *path;
> +	dbus_bool_t value;
> +
> +	if (cm == NULL)
> +		return;
> +
> +	cdma_connman_settings_reset(cm);
> +	value = FALSE;
> +	path = __ofono_atom_get_path(cm->atom);

Don't you also want to reset cm->powered accordingly?

> +
> +	ofono_dbus_signal_property_changed(conn, path,
> +				OFONO_CDMA_CONNECTION_MANAGER_INTERFACE,
> +				"Powered", DBUS_TYPE_BOOLEAN, &value);
> +}
> +
>  static void cdma_connman_unregister(struct ofono_atom *atom)
>  {
>  	DBusConnection *conn = ofono_dbus_get_connection();

Regards,
-Denis