From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCHv2 1/6] gatchat: Add IPv6 Control Protocol
Date: Sun, 13 Nov 2011 15:29:42 -0600 [thread overview]
Message-ID: <4EC036C6.4020605@gmail.com> (raw)
In-Reply-To: <4EC0D96C.2070700@intel.com>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
Hi Oleg,
On 11/14/2011 03:03 AM, Oleg Zhurakivskyy wrote:
> Hello Denis,
>
>> The break statement seems to be in error and I fixed it in a follow on
>> commit. Let me know if I was wrong.
>
> Yes, that is error, thanks for correction. And sorry for the mistake.
>
> What is still missing from the integration point of view? Thanks in
> advance!
I've reviewed the other patches, however I'm not completely happy with
the API changes and a few scenarios do not seem to work. I spent most
of Friday trying to figure out better alternatives, but have not come up
with anything yet. Let it stew in my brain for a bit longer.
Regards,
-Denis
next prev parent reply other threads:[~2011-11-13 21:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 12:46 [PATCHv2 0/6] gatchat IPv6 CP support Oleg Zhurakivskyy
2011-11-08 12:46 ` [PATCHv2 1/6] gatchat: Add IPv6 Control Protocol Oleg Zhurakivskyy
2011-11-07 18:26 ` Denis Kenzior
2011-11-14 9:03 ` Oleg Zhurakivskyy
2011-11-13 21:29 ` Denis Kenzior [this message]
2011-11-08 12:46 ` [PATCHv2 2/6] gatppp: Add IPv6 CP hooks Oleg Zhurakivskyy
2011-11-15 2:53 ` Denis Kenzior
2011-11-16 12:39 ` Oleg Zhurakivskyy
2011-11-15 13:59 ` Denis Kenzior
2011-11-17 8:05 ` Oleg Zhurakivskyy
2011-11-08 12:46 ` [PATCHv2 3/6] gsmdial: Add IPv6 CP option Oleg Zhurakivskyy
2011-11-08 12:46 ` [PATCHv2 4/6] test-server: Add IPv6 CP options Oleg Zhurakivskyy
2011-11-08 12:46 ` [PATCHv2 5/6] gatppp: Add IPv6 CP connect, disconnect callbacks Oleg Zhurakivskyy
2011-11-15 2:59 ` Denis Kenzior
2011-11-16 14:05 ` Oleg Zhurakivskyy
2011-11-15 13:43 ` Denis Kenzior
2011-11-17 8:10 ` Oleg Zhurakivskyy
2011-11-08 12:46 ` [PATCHv2 6/6] gsmdial: Add IPv6 CP connect hook Oleg Zhurakivskyy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC036C6.4020605@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox