From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] cdmamodem: Support speedup dormant notification
Date: Sat, 10 Dec 2011 17:33:12 -0600 [thread overview]
Message-ID: <4EE3EC38.7020607@gmail.com> (raw)
In-Reply-To: <1323688297-2538-2-git-send-email-guillaume.zajac@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
Hi Guillaume,
On 12/12/2011 05:11 AM, Guillaume Zajac wrote:
> ---
> drivers/cdmamodem/connman.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/cdmamodem/connman.c b/drivers/cdmamodem/connman.c
> index 8c3265a..41708f7 100644
> --- a/drivers/cdmamodem/connman.c
> +++ b/drivers/cdmamodem/connman.c
> @@ -264,6 +264,11 @@ static void at_c0_cb(gboolean ok, GAtResult *result, gpointer user_data)
> }
>
> switch (cd->vendor) {
> + case OFONO_VENDOR_SPEEDUP:
> + /*
> + * Fall through: SpeedUp modem uses same prefix as Huawei
> + * modem for dormant notification.
> + */
If the handling is exactly the same, then it is better to just skip this
step. Using OFONO_VENDOR_HUAWEI from the speedup plugin is just fine.
> case OFONO_VENDOR_HUAWEI:
> chat = g_at_chat_get_slave(cd->chat);
> g_at_chat_register(chat, "^DSDORMANT", huawei_dsdormant_notify,
Regards,
-Denis
next prev parent reply other threads:[~2011-12-10 23:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 11:11 [PATCH 0/2] Add dormant notification support for speedupcdma modems Guillaume Zajac
2011-12-12 11:11 ` [PATCH 1/2] cdmamodem: Support speedup dormant notification Guillaume Zajac
2011-12-10 23:33 ` Denis Kenzior [this message]
2011-12-12 11:11 ` [PATCH 2/2] speedupcdma: Tweak plugin to notify dormant state Guillaume Zajac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE3EC38.7020607@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox