From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC v3 12/16] elect: Add skeleton dial implementation
Date: Wed, 14 Dec 2011 19:15:29 -0600 [thread overview]
Message-ID: <4EE94A31.50201@gmail.com> (raw)
In-Reply-To: <1323788410-9988-13-git-send-email-wagi@monom.org>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
Hi Daniel,
On 12/13/2011 09:00 AM, Daniel Wagner wrote:
> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> ---
> Makefile.am | 3 +-
> elect/dial.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> elect/elect.h | 16 +++++++++++
> 3 files changed, 101 insertions(+), 1 deletions(-)
> create mode 100644 elect/dial.c
>
Personally I'm having trouble seeing what this abstraction is really
buying you. There's really only one way to establish a PPP connection,
so much of this file is just overhead and can easily live inside
device.c. But maybe I am missing something here...
Regards,
-Denis
next prev parent reply other threads:[~2011-12-15 1:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 14:59 [RFC v3 00/16] Add DUN support Daniel Wagner
2011-12-13 14:59 ` [RFC v3 01/16] elect: Add skeleton implementation Daniel Wagner
2011-12-13 14:59 ` [RFC v3 02/16] elect: Add D-Bus error messages Daniel Wagner
2011-12-13 14:59 ` [RFC v3 03/16] elect: Add D-Bus configuration file Daniel Wagner
2011-12-13 14:59 ` [RFC v3 04/16] elect: Add systemd " Daniel Wagner
2011-12-13 14:59 ` [RFC v3 05/16] elect: Add Manager interface Daniel Wagner
2011-12-13 15:00 ` [RFC v3 06/16] elect: Add skeleton implementation for device Daniel Wagner
2011-12-13 15:00 ` [RFC v3 07/16] elect: Manager append devices Daniel Wagner
2011-12-13 15:00 ` [RFC v3 08/16] bluetooth: Add Serial interface definition Daniel Wagner
2011-12-13 15:00 ` [RFC v3 09/16] elect: Add BlueZ hooks to device Daniel Wagner
2011-12-13 15:00 ` [RFC v3 10/16] elect: Add device D-Bus interface Daniel Wagner
2011-12-13 15:00 ` [RFC v3 11/16] elect: Dis/Connect Serial interface Daniel Wagner
2011-12-15 0:56 ` Denis Kenzior
2011-12-13 15:00 ` [RFC v3 12/16] elect: Add skeleton dial implementation Daniel Wagner
2011-12-15 1:15 ` Denis Kenzior [this message]
2011-12-13 15:00 ` [RFC v3 13/16] elect: Add ppp callbacks to device Daniel Wagner
2011-12-13 15:00 ` [RFC v3 14/16] elect: Add GatChat and PPP handler Daniel Wagner
2011-12-15 1:20 ` Denis Kenzior
2011-12-13 15:00 ` [RFC v3 15/16] elect: Add test scripts Daniel Wagner
2011-12-13 15:00 ` [RFC v3 16/16] elect: Add documentation Daniel Wagner
2011-12-15 1:10 ` Denis Kenzior
2011-12-16 8:44 ` Daniel Wagner
2011-12-16 9:40 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE94A31.50201@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox