From: Daniel Wagner <wagi@monom.org>
To: ofono@ofono.org
Subject: Re: [RFC v0] ofono: Only register network when APN is set
Date: Tue, 28 Feb 2012 11:02:30 +0100 [thread overview]
Message-ID: <4F4CA636.2000503@monom.org> (raw)
In-Reply-To: <1330420763-8244-1-git-send-email-wagi@monom.org>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
O> dbus_message_iter_next(dict);
> @@ -1180,6 +1188,19 @@ static gboolean context_changed(DBusConnection *connection,
> set_connected(modem);
> else
> set_disconnected(modem);
> + } else if (g_str_equal(key, "AccessPointName") == TRUE) {
> + g_free(modem->apn);
> +
> + dbus_message_iter_get_basic(&value, &modem->apn);
> +
> + DBG("%s AccessPointName %s", modem->path, modem->apn);
> +
> + if (has_interface(modem->interfaces,
> + OFONO_API_NETREG) == TRUE &&
> + modem->network != NULL) {
> + DBG("Register network at core");
> + add_network(modem);
> + }
that should be a "modem->network == NULL" of course.
next prev parent reply other threads:[~2012-02-28 10:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 15:20 trying to understand context creation Jussi Kukkonen
2012-02-21 14:03 ` Denis Kenzior
2012-02-22 9:58 ` Jussi Kukkonen
2012-02-22 9:19 ` Denis Kenzior
2012-02-24 11:55 ` Jussi Kukkonen
2012-02-24 5:12 ` Denis Kenzior
2012-02-24 16:13 ` Jussi Kukkonen
2012-02-24 7:20 ` Denis Kenzior
2012-02-27 9:25 ` Jussi Kukkonen
2012-02-27 10:54 ` Marcel Holtmann
2012-02-27 13:20 ` Jussi Kukkonen
2012-02-27 17:30 ` Marcel Holtmann
2012-02-28 9:19 ` [RFC v0] ofono: Only register network when APN is set Daniel Wagner
2012-02-28 10:02 ` Daniel Wagner [this message]
2012-02-28 14:06 ` Jussi Kukkonen
2012-02-28 16:33 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4CA636.2000503@monom.org \
--to=wagi@monom.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox