Open Source Telephony
 help / color / mirror / Atom feed
From: Frederic Danis <frederic.danis@linux.intel.com>
To: ofono@ofono.org
Subject: Re: [PATCH] phonesim: Fix AT+CHLD=1x
Date: Wed, 14 Mar 2012 12:39:33 +0100	[thread overview]
Message-ID: <4F608375.3040503@linux.intel.com> (raw)
In-Reply-To: <4F6004B7.8050608@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

Hello Denis,

Le 14/03/2012 03:38, Denis Kenzior a écrit :
> Hi Frédéric,
>
> On 03/13/2012 09:33 AM, Frédéric Danis wrote:
>> AT+CHLD=1x should only hangup active call
>> ---
>>   src/callmanager.cpp |   38 ++++++++++++++++++++++++--------------
>>   1 files changed, 24 insertions(+), 14 deletions(-)
>>
>
> What are you trying to fix here?  Phonesim models the behavior of an
> 'ideal' modem which can hangup any call using release_specific.  Plenty
> of modems exhibit this behavior via vendor specific AT commands, so if
> this is related to HFP emulation then we probably need to do something else.
>
> Regards,
> -Denis
>

I found this during tests around AT+CHLD commands.
I just follows HFP and 3GPP specs about the AT+CHLD=1x command : 
"Releases a specific active call X.".
But if this is the attended behavior in phonesim, just forget my patch.

Regards

Fred

-- 
Frederic Danis                            Open Source Technology Center
frederic.danis(a)intel.com                              Intel Corporation


      reply	other threads:[~2012-03-14 11:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13 14:33 [PATCH] phonesim: Fix AT+CHLD=1x =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2012-03-14  2:38 ` Denis Kenzior
2012-03-14 11:39   ` Frederic Danis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F608375.3040503@linux.intel.com \
    --to=frederic.danis@linux.intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox