From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCHv2] sim: Use quoted string with AT+CRSM data parameter
Date: Fri, 23 Mar 2012 08:39:51 -0500 [thread overview]
Message-ID: <4F6C7D27.40802@gmail.com> (raw)
In-Reply-To: <1332437290-31190-1-git-send-email-nicolas.bertrand@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
Hi Nicolas,
On 03/22/2012 12:28 PM, Nicolas Bertrand wrote:
> Fix issue with some modems preventing to update elementary files
> (speedup, ZTE, huawei, MBM)
> ---
> drivers/atmodem/sim.c | 127 ++++++++++++++++---------------------------------
> 1 files changed, 41 insertions(+), 86 deletions(-)
>
Patch has been applied, but I had to fix up numerous coding style
violations afterwards. Please re-read doc/coding-style.txt and pay
extra attention next time.
Just one more comment:
> + sprintf(buf + len, "%s", quote);
>
Something like this is really wasteful, you're invoking sprintf (which
is quite a heavy hammer) just to put in a quote character. Use buf[len]
= '\"' next time.
Regards,
-Denis
prev parent reply other threads:[~2012-03-23 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 17:28 [PATCHv2] sim: Use quoted string with AT+CRSM data parameter Nicolas Bertrand
2012-03-23 13:39 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6C7D27.40802@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox