Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] ussd: Fix speedup ussd encoding
Date: Tue, 10 Apr 2012 02:53:02 -0500	[thread overview]
Message-ID: <4F83E6DE.7040203@gmail.com> (raw)
In-Reply-To: <1334072105-32105-3-git-send-email-nicolas.bertrand@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

Hi Nicolas,

On 04/10/2012 10:35 AM, Nicolas Bertrand wrote:
> Speedup dongles encode USSD strings in GSM7
> packed, so we don't have to pack it ourselves.
> ---
>  drivers/atmodem/ussd.c |   13 ++++++++++---
>  plugins/speedup.c      |    2 +-
>  2 files changed, 11 insertions(+), 4 deletions(-)
> 

Patch looks good, but please split it into two in accordance with our
patch submission guidelines.  See HACKING document, 'Submitting patches'
section.

Regards,
-Denis

  reply	other threads:[~2012-04-10  7:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-10 15:35 [PATCH 0/2] ussd fixes Nicolas Bertrand
2012-04-10 15:35 ` [PATCH 1/2] ussd: rise up buffer lenght for ussd strings Nicolas Bertrand
2012-04-10 13:55   ` Denis Kenzior
2012-04-10 15:35 ` [PATCH 2/2] ussd: Fix speedup ussd encoding Nicolas Bertrand
2012-04-10  7:53   ` Denis Kenzior [this message]
2012-04-10 21:22     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F83E6DE.7040203@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox