From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] hfpmodem: use full CLCC handling in dialing case
Date: Wed, 11 Apr 2012 23:56:26 -0500 [thread overview]
Message-ID: <4F86607A.8080304@gmail.com> (raw)
In-Reply-To: <1334172998-3969-1-git-send-email-puffy.taco@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 955 bytes --]
Hi Michael,
On 04/11/2012 02:36 PM, Mike Brudevold wrote:
> From: Michael Brudevold <michael.brudevold@logicpd.com>
>
> A call that moves from the dialing to active state before the +CLCC response
> will not properly be added as a voicecall. This is because the dialing callback
> was using simplified handling and only looked for calls in the dialing or
> alerting state.
>
> AT sequence that exhibited the failure (AG device was an iPhone accessing
> visual voicemail):
>
>> +CIND: ("service",(0-1)),("call",(0-1)),("callsetup",(0-3)),
> ("battchg",(0-5)),("signal",(0-5)),("roam",(0-1)),("callheld",(0-2))
> ...
>> +CIEV: 3,2
> < AT+CLCC
>> +CIEV: 2,1
>> +CIEV: 3,0
>> +CLCC: 1,0,0,0,0,"**21153**",129,"Voicemail"
> ---
> drivers/hfpmodem/voicecall.c | 68 +-----------------------------------------
> 1 files changed, 1 insertions(+), 67 deletions(-)
>
Patch looks good to me. Applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2012-04-12 4:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 19:36 [PATCH] hfpmodem: use full CLCC handling in dialing case Mike Brudevold
2012-04-12 4:56 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F86607A.8080304@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox