Re: [PATCH] voicecall: fix release and answer existing call validation

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]

Hi Michael,

On 04/19/2012 05:10 PM, Mike Brudevold wrote:
> From: Michael Brudevold <michael.brudevold@logicpd.com>
> 
> Release and answer should be allowed when there are held calls as well as the
> existing check for waiting calls.  Most implementations use AT+CHLD=1 which
> will resume the other call, be it waiting or held.  This follows the HFP,
> GSM 07.07 and 3GPP 27.007 specs.
> ---
>  src/voicecall.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 

This isn't really a bug, but an explicit choice we made with the API.
See the previous discussion here:
http://lists.ofono.org/pipermail/ofono/2011-January/008029.html.

For HFP this is further made funny by the fact that CHLD=1X is supposed
to retrieve the held call automatically for you by the AG according to
section 4.32.1, making CHLD=1 behavior in question somewhat redundant.

However, I do see that this could be useful, so I suggest we add a new
ReleaseAndSwap method.  I prefer this approach especially since the
current D-Bus API is frozen and I don't want to modify the behavior of
existing methods.

Regards,
-Denis