From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] n950: Add new plugin for Nokia N950
Date: Wed, 30 May 2012 00:53:21 -0500 [thread overview]
Message-ID: <4FC5B5D1.8040100@gmail.com> (raw)
In-Reply-To: <1337018591-6553-2-git-send-email-aki.niemi@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
Hi Aki,
On 05/14/2012 01:03 PM, Aki Niemi wrote:
> ---
> plugins/n950.c | 563 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 563 insertions(+), 0 deletions(-)
> create mode 100644 plugins/n950.c
>
Running diff plugins/n950.c plugins/n900.c I see no differences to note
besides:
< DBG("Error: %s", g_isi_msg_strerror(msg));
---
> DBG("Error: %s", strerror(-g_isi_msg_error(msg)));
Do we really need a new driver for the n950?
Regards,
-Denis
next prev parent reply other threads:[~2012-05-30 5:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 18:03 [PATCH 1/4] n900: Use consistent naming in GPIO API Aki Niemi
2012-05-14 18:03 ` [PATCH 2/4] n950: Add new plugin for Nokia N950 Aki Niemi
2012-05-30 5:53 ` Denis Kenzior [this message]
2012-05-14 18:03 ` [PATCH 3/4] build: Add n950 plugin to build Aki Niemi
2012-05-14 18:03 ` [PATCH 4/4] udev: Add bootstrapping for n950 plugin Aki Niemi
2012-05-30 5:54 ` [PATCH 1/4] n900: Use consistent naming in GPIO API Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC5B5D1.8040100@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox