Open Source Telephony
 help / color / mirror / Atom feed
From: Simon Busch <morphis@gravedo.de>
To: ofono@ofono.org
Subject: Re: [PATCH] control: use correct dbus error domain
Date: Thu, 12 Jul 2012 18:33:36 +0200	[thread overview]
Message-ID: <4FFEFC60.4040303@gravedo.de> (raw)
In-Reply-To: <4FFEF8A2.1050108@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

Am 12.07.2012 18:17, schrieb Denis Kenzior:
> Hi Simon,
>
> On 07/12/2012 03:06 AM, Simon Busch wrote:
>> Before it was org.ofono.phonesimError but should be consistent with
>> the other error
>> reports and should use org.ofono.phonesim.Error.
>>
>> Signed-off-by: Simon Busch<morphis@gravedo.de>
>
> Please note that we do not use Signed-off-by


Ok, will consider this the next time.

>> ---
>>   src/control.cpp |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Patch has been applied, thanks.

Thanks a lot.

regards,
Simon

-- 
Simon Busch - http://mm.gravedo.de/blog/



      reply	other threads:[~2012-07-12 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12  8:06 [PATCH] phonesim: one small fix regarding the dbus interface Simon Busch
2012-07-12  8:06 ` [PATCH] control: use correct dbus error domain Simon Busch
2012-07-12 16:17   ` Denis Kenzior
2012-07-12 16:33     ` Simon Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFEFC60.4040303@gravedo.de \
    --to=morphis@gravedo.de \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox