Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] qmimodem/network-registration: register callbacks after ofono_netreg_register()
Date: Mon, 11 Sep 2017 10:41:53 -0500	[thread overview]
Message-ID: <4db1e202-723c-eb2a-5885-e65f796dbb74@gmail.com> (raw)
In-Reply-To: <20170911002543.31030-2-lynxis@fe80.eu>

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi Alexander,

On 09/10/2017 07:25 PM, Alexander Couzens wrote:
> When registering callbacks before ofono_netreg_register(), callbacks
> will use the netreg api which might lead into undefined behaviour,
> because certain fields aren't yet initilized.
> ---
>   drivers/qmimodem/network-registration.c | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)

Applied, thanks.

Regards,
-Denis


  reply	other threads:[~2017-09-11 15:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11  0:25 [PATCH 1/2] network.c: notify_status_watches: check for NULL Alexander Couzens
2017-09-11  0:25 ` [PATCH 2/2] qmimodem/network-registration: register callbacks after ofono_netreg_register() Alexander Couzens
2017-09-11 15:41   ` Denis Kenzior [this message]
2017-09-11 15:39 ` [PATCH 1/2] network.c: notify_status_watches: check for NULL Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4db1e202-723c-eb2a-5885-e65f796dbb74@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox