From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCHv2 2/3] doc: Describe DBus method to set delivery-report
Date: Wed, 08 Aug 2012 12:06:58 -0500 [thread overview]
Message-ID: <50229CB2.4090800@gmail.com> (raw)
In-Reply-To: <1344432106-23105-3-git-send-email-ronald.tessier@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
Hi Ronald,
On 08/08/2012 08:21 AM, Ronald Tessier wrote:
> ---
> doc/service-api.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
I applied this patch, but see below.
> diff --git a/doc/service-api.txt b/doc/service-api.txt
> index 02396ff..25f2d0d 100644
> --- a/doc/service-api.txt
> +++ b/doc/service-api.txt
> @@ -82,6 +82,12 @@ Methods array{object,dict} GetMessages()
>
> Possible Errors: [service].Error.InvalidArguments
>
> + void SetProperty(string name, variant value)
> +
> + Changes the value of the specified property.
> +
> + Possible Errors: [service].Error.InvalidArguments
> +
You are still missing GetProperties doc additions and implementation.
Please send these as separate patches.
Regards,
-Denis
next prev parent reply other threads:[~2012-08-08 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 13:21 [PATCHv2 0/3] mmsd: delivery-report flag Ronald Tessier
2012-08-08 13:21 ` [PATCHv2 1/3] service: Add DBus method to set delivery-report Ronald Tessier
2012-08-08 17:06 ` Denis Kenzior
2012-08-08 13:21 ` [PATCHv2 2/3] doc: Describe " Ronald Tessier
2012-08-08 17:06 ` Denis Kenzior [this message]
2012-08-08 13:21 ` [PATCHv2 3/3] test: Add a script to set the delivery-report flag Ronald Tessier
2012-08-08 17:07 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50229CB2.4090800@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox