Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 6/8] gprs: data bearer for telit with PSNT
Date: Tue, 14 Aug 2012 01:53:06 -0500	[thread overview]
Message-ID: <5029F5D2.5060304@gmail.com> (raw)
In-Reply-To: <502A7133.1010307@hale.at>

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

Hi Christopher,

>> Do you really need to query this? In theory if we are turning off
>> auto-attach, we should never be in a state where the bearer should be
>> queried.
> Once '#PSNT=1' is sent, the modem emits #PSNT URCs even just after
> enabling the modem (e.g. after changing the SIM or setting the modem
> online again).

By the way, the gprs atom is meant to be put into the post_sim phase now.

> So if the value does not change incidentally in gprs phase, the modem
> will not send an URC. That's why I added the query. Is this ok in this
> case?

I still don't see how it can not change.  If you go offline you should 
be detached and only attaching once the gprs atom tells you to.  I 
presume the PSNT will change during / after the attach procedure 
completes, not before.  That means just the URC is enough.  Same with 
sim change, etc.

Lets get a version of this patch upstream without the query.  If you can 
show that we still need to query then I have no problems pushing that 
afterwards as well.

Regards,
-Denis

  reply	other threads:[~2012-08-14  6:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 13:23 [PATCH 6/8] gprs: data bearer for telit with PSNT Christopher Vogl
2012-08-13 14:48 ` Denis Kenzior
2012-08-14 15:39   ` Christopher Vogl
2012-08-14  6:53     ` Denis Kenzior [this message]
2012-08-16  8:11       ` [PATCH] " Christopher Vogl
2012-08-16  6:12         ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5029F5D2.5060304@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox