From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] gprs: skip CGAUTO for telit
Date: Thu, 16 Aug 2012 01:24:31 -0500 [thread overview]
Message-ID: <502C921F.803@gmail.com> (raw)
In-Reply-To: <1345109629-29468-1-git-send-email-christopher.vogl@hale.at>
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
Hi Christopher,
On 08/16/2012 04:33 AM, Christopher Vogl wrote:
> Telit does not support +CGAUTO and will just return an error.
> To not confuse people reading the debug output, don't send the command
> for telit.
> ---
> drivers/atmodem/gprs.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
> index 65a8b7b..4e0823c 100644
> --- a/drivers/atmodem/gprs.c
> +++ b/drivers/atmodem/gprs.c
> @@ -342,7 +342,11 @@ retry:
> goto error;
>
> g_at_chat_send(gd->chat, cmd, none_prefix, NULL, NULL, NULL);
> - g_at_chat_send(gd->chat, "AT+CGAUTO=0", none_prefix, NULL, NULL, NULL);
> +
> + if (gd->vendor == OFONO_VENDOR_TELIT)
> + DBG("Telit does not support +CGAUTO command.");
> + else
> + g_at_chat_send(gd->chat, "AT+CGAUTO=0", none_prefix, NULL, NULL, NULL);
What are you gaining by printing the above message and not sending the
CGAUTO?
>
> switch (gd->vendor) {
> case OFONO_VENDOR_MBM:
Regards,
-Denis
prev parent reply other threads:[~2012-08-16 6:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 13:22 [PATCH 4/8] gprs: add quirk for Telit modems Christopher Vogl
2012-08-13 13:36 ` Denis Kenzior
2012-08-16 9:33 ` [PATCH] gprs: skip CGAUTO for telit Christopher Vogl
2012-08-16 6:24 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502C921F.803@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox