Open Source Telephony
 help / color / mirror / Atom feed
From: Guillaume Zajac <guillaume.zajac@linux.intel.com>
To: ofono@ofono.org
Subject: [RFC] Multi-recipient SMS implementation proposals
Date: Fri, 24 Aug 2012 12:08:03 +0200	[thread overview]
Message-ID: <50375283.9080600@linux.intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]

Hi all,

Mutli-recipient SMS implementation is needed to pass GCF test cases 
34.2.9.1 and 34.2.9.2 for GSM; 16.1.9.1 and 16.1.9.2 for WCDMA.
A new task should be added to oFono TODO and as requested by Denis we 
have to discuss first the proposals.
I have in mind 2 solutions:

1- Add a new API in message manager methods using an array of string 
containing all the recipients and returning an array of message paths:
GDBUS_ASYNC_METHOD("SendMultipleMessage",
         GDBUS_ARGS({ "to", "a{s}" }, { "text", "s" }),
         GDBUS_ARGS({ "paths", "a{o}" }),
         sms_send_multiple_message)
It requires also to implement a new function in core based on 
__ofono_sms_txq_submit() to fill in the TX queue with all recipients 
before submitting the message.

2-Modify existing SendMessage API in adding a new mms argument:
GDBUS_ASYNC_METHOD("SendMessage",
         GDBUS_ARGS({ "to", "s" }, { "text", "s" }, { "mms", "i" }),
         GDBUS_ARGS({ "path", "o" }),
         sms_send_message)
It requires to add a new field in struct ofono_sms like 'int send_mms'.
tx_next() function should be modified to check 'int mms' option before 
analysing the TX queue size.
We should determine if send_mms = 2 options could be used. Even if we 
don't use it, send_mms should be set to 0 once all the multi-recipient 
SMS have been transmitted.

Kind regards,
Guillaume

             reply	other threads:[~2012-08-24 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24 10:08 Guillaume Zajac [this message]
2012-08-24 22:31 ` [RFC] Multi-recipient SMS implementation proposals Marcel Holtmann
2012-08-27  8:06   ` Guillaume Zajac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50375283.9080600@linux.intel.com \
    --to=guillaume.zajac@linux.intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox