From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/3] phonesim: Extend conformance menu with Setup Call items
Date: Wed, 05 Sep 2012 15:12:23 -0500 [thread overview]
Message-ID: <5047B227.2020004@gmail.com> (raw)
In-Reply-To: <1346865667-24888-1-git-send-email-philippe.nunes@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 3225 bytes --]
Hi Philippe,
On 09/05/2012 12:21 PM, Philippe Nunes wrote:
> ---
> src/conformancesimapplication.cpp | 247 +++++++++++++++++++++++++++++++++++++
> src/simapplication.h | 2 +
> 2 files changed, 249 insertions(+)
<snip>
>
> + case SetupCall_Max_Dialing_Number:
> + {
> + cmd.setType( QSimCommand::SetupCall );
> + cmd.setDestinationDevice( QSimCommand::Network );
> + cmd.setNumber( "+01234567890123456789012345678901" );
> + cmd.setDisposition( QSimCommand::Disconnect );
> + command( cmd, this, SLOT(sendSetupCallMenu()) );
> + }
> + break;
Can we actually fix the inconsistent indentation here?
> +
> + case SetupCall_Two_AID:
> + {
> + cmd.setType( QSimCommand::SetupCall );
> + cmd.setDestinationDevice( QSimCommand::Network );
> + cmd.setText( "CONFIRMATION" );
> + cmd.setOtherText( "CALL" );
> + cmd.setNumber( "+012340123456p1p2" );
> + cmd.setDisposition( QSimCommand::Disconnect );
> + command( cmd, this, SLOT(sendSetupCallMenu()) );
> + }
> + break;
And here?
> +
> + case SetupCall_Basic_icon:
> + {
> + cmd.setType( QSimCommand::SetupCall );
> + cmd.setDestinationDevice( QSimCommand::Network );
> + cmd.setText( "Set up call Icon 3.1.1" );
> + cmd.setNumber( "+012340123456p1p2" );
> + cmd.setIconId( 1 );
> + cmd.setIconSelfExplanatory( false );
> + cmd.setDisposition( QSimCommand::IfNoOtherCalls );
> + command( cmd, this, SLOT(sendSetupCallMenu()) );
> + }
> + break;
> +
> + case SetupCall_Self_basic_icon:
> + {
> + cmd.setType( QSimCommand::SetupCall );
> + cmd.setDestinationDevice( QSimCommand::Network );
> + cmd.setText( "Set up call Icon 3.2.1" );
> + cmd.setNumber( "+012340123456p1p2" );
> + cmd.setIconId( 1 );
> + cmd.setIconSelfExplanatory( true );
> + cmd.setDisposition( QSimCommand::IfNoOtherCalls );
> + command( cmd, this, SLOT(sendSetupCallMenu()) );
> + }
> + break;
And here
> +
> + case SetupCall_Basic_icon_during_call:
> + {
> + cmd.setType( QSimCommand::SetupCall );
> + cmd.setDestinationDevice( QSimCommand::Network );
> + cmd.setText( "Set up call Icon 3.4.1" );
> + cmd.setNumber( "+012340123456p1p2" );
> + cmd.setIconId( 1 );
> + cmd.setIconSelfExplanatory( true );
> + cmd.setOtherText( "Set up call Icon 3.4.2" );
> + cmd.setOtherIconId( 1 );
> + cmd.setOtherIconSelfExplanatory( true );
> + cmd.setDisposition( QSimCommand::IfNoOtherCalls );
> + command( cmd, this, SLOT(sendSetupCallMenu()) );
> + }
> + break;
And here.
> +
> + default:
> + endSession();
> + break;
> + }
> +}
Regards,
-Denis
prev parent reply other threads:[~2012-09-05 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 17:21 [PATCH 1/3] phonesim: Extend conformance menu with Setup Call items Philippe Nunes
2012-09-05 17:21 ` [PATCH 2/3] phonesim: Add text for PlayTone and Send SS Philippe Nunes
2012-09-05 20:13 ` Denis Kenzior
2012-09-05 17:21 ` [PATCH 3/3] phonesim: Reject specific outgoing call for SAT test purpose Philippe Nunes
2012-09-05 20:14 ` Denis Kenzior
2012-09-05 20:12 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5047B227.2020004@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox